Review main Merged

11157[BUGFIX] Fix 2 CGL violations in alt_shortcut.php.

mostwanted CR +2 V +2 Easy +3 −1 updated 06/03/13, 20:49

Commit message

on metrics.typo3.org the violations drilldown says
that is 1 violation against
"FunctionCallArgumentSpacingNoSpaceAfterEquals"
and 1 violation against
"FunctionCallArgumentSpacingNoSpaceBeforeEquals":
both in typo3/alt_shortcut.php.

this should be fixed.

after that i guess these 2 coding guidline sniffs
could be activated in the CI-server jobs?

Review

  • Code review CR +2
    • Georg Ringer +2
    • mostwanted +1
  • Verified V +2
    • Georg Ringer +2
    • mostwanted +1

Files 1

Review log 9

  1. mostwanted commented on patch set 1 05/14/12, 08:21

    (1 inline comment)
  2. Georg Ringer commented on patch set 1 05/14/12, 08:21

    (1 inline comment)

    alt_shortcut.php:318

    shouldnt be a space after the ',' ?
  3. mostwanted commented on patch set 2 05/14/12, 08:21

    Verified; Looks good to me, but someone else must approve Looks good to me.
  4. Georg Ringer uploaded patch set 2 05/14/12, 08:21

  5. Georg Ringer commented on patch set 2 V 0 05/14/12, 08:21

    by team member; Looks good to me, approved
  6. Georg Ringer commented on patch set 2 05/14/12, 08:21

    if you can give your +1 on reading + testing I can push that directly
  7. Mr. Jenkins commented on patch set 1 05/14/12, 08:21

  8. Mr. Jenkins commented on patch set 2 05/14/12, 08:21

  9. Georg Ringer merged patch set 2 05/14/12, 08:21