Review main Merged

11229[TASK] Fix whitespace in t3lib_befunc

Christian Kuhn CR +2 V +2 Easy +9 −9 updated 06/03/13, 20:49

Commit message

This made jenkins unhappy with
https://review.typo3.org/#/c/11225/3

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 1

Review log 5

  1. Christian Kuhn commented on patch set 1 V 0 05/16/12, 17:25

    by team member; Looks good to me, approved
  2. Christian Kuhn merged patch set 1 05/16/12, 17:25

  3. Stefano Kowalke commented on patch set 1 05/16/12, 17:25

    The reason for complaining was not the whitespaces you fixed. These whitespaces are inside a string (SQL Statement) and will ignored by our Sniff. I looks more like, that the changeset in question based on an old repo state (one before fixing the whitespace issue in this file). As Gerrit triggers Jenkins and passes the changeset to him. Jenkins checks out the whole core on state of that changeset and apply it to the core. As result you got issues which was already fixed. You can proof this by have a look at the nightly job [1] where no DissallowSpaceIndent violation was found for this file To make it short: A simple rebase of the local repo and pushing the patch again will make Mr. Jenkins smile. [1] https://ci.typo3.org/view/TYPO3/view/Core/job/typo3-v4-core-nightly/518/checkstyleResult/file.1549038953/category.-2054143363/
  4. Mr. Jenkins commented on patch set 1 05/16/12, 17:25

  5. Christian Kuhn commented on patch set 1 05/16/12, 17:25

    Thanks for your explanations Stefano! Will keep that in mind. Still the code is a bit more clean now, so it doesn't harm ^^