Review main Merged

11249[BUGFIX] sectionIndex menu is not i18n ready

Stefan Galinski CR +2 V +2 Hard +260 −42 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Klein +1
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Files 3

Review log 53

Show 28 earlier messages
  1. Stefan Galinski commented on patch set 1 08/07/12, 19:10

    Fails; Do not submit

    class.tslib_menu.php:1683 Reply

    Could be done, but IMHO it's more readable in this way.

    class.tslib_menu.php:1762 Reply

    Done

    class.tslib_menu.php:1770 Reply

    Done

    class.tslib_menu.php:1779 Reply

    Testable with: config.sys_language_overlay = 0 Possible solution: colPos=0 AND (sys_language_uid IN (-1, 0) OR (sys_language_uid = ' . $GLOBALS['TSFE']->sys_language_content . ' AND l18n_parent = 0) What do you think?

    class.tslib_menu.php:1784 Reply

    You will fallback directly to the configured language if set, so this should be ok. Which problems do you see?

    class.tslib_menu.php:1797 Reply

    Just looked at the other occurences and they are using contentOL too.
  2. Stefan Galinski uploaded patch set 2 08/07/12, 19:10

  3. Stefan Galinski commented on patch set 2 08/07/12, 19:10

    No score
  4. Stefan Galinski commented on patch set 2 08/07/12, 19:10

    The whole multilanguage handling of the method was a mess and didn't worked in any way like it would be expected. Section menus are currently completly broken and unusable with TYPO3 4.7. Also because of the missing where clause manipulation that is currently set hardcoded to colPos=0, but this change can be found in the other review request.
  5. Markus Klein commented on patch set 3 08/07/12, 19:10

    (1 inline comment)

    class.tslib_menu.php:1683

    What about merging all this into one condition?
  6. Markus Klein commented on patch set 3 08/07/12, 19:10

    (2 inline comments)
  7. Stefan Galinski uploaded patch set 3 08/07/12, 19:10

  8. Stefan Galinski commented on patch set 3 08/07/12, 19:10

    (1 inline comment)
  9. Stefan Galinski commented on patch set 3 08/07/12, 19:10

    I have refactored the whole method and fixed the broken multilanguage code. This is still a bugfix as this code must be backported to 4.7, because the sectionIndex menus are completely broken there.
  10. Markus Klein commented on patch set 4 08/07/12, 19:10

    Looks good to me, but someone else must approve Maybe we could use intval() on ["sectionIndex"] too. The extra parentheses around the conditions are superfluous, but you can keep them for readabilitiy.
  11. Stefan Galinski commented on patch set 4 08/07/12, 19:10

    The sectionIndex variable is a checkbox (=boolean value) and an intval would be just wasted performance for this condition. Thanks for your code review!
  12. Stefan Galinski uploaded patch set 4 08/07/12, 19:10

  13. Stefan Galinski commented on patch set 4 08/07/12, 19:10

    Changes: - merged conditions like requested by Markus This change was pretty easy, thanks to the new unit tests. :-)
  14. Markus Klein commented on patch set 5 08/07/12, 19:10

    (3 inline comments)
  15. Stefan Galinski uploaded patch set 5 08/07/12, 19:10

  16. Stefan Galinski commented on patch set 5 08/07/12, 19:10

    Just rebased the patch.
  17. Stefan Galinski commented on patch set 5 08/07/12, 19:10

    (3 inline comments)
  18. Markus Klein commented on patch set 6 08/07/12, 19:10

    (1 inline comment)
  19. Markus Klein commented on patch set 6 08/07/12, 19:10

    (1 inline comment)
  20. Markus Klein commented on patch set 6 08/07/12, 19:10

    (1 inline comment)
  21. Markus Klein commented on patch set 7 1 comment 08/07/12, 19:10

    I would prefer that you didn't submit this
  22. Markus Klein commented on patch set 7 08/07/12, 19:10

    (2 inline comments)
  23. Markus Klein uploaded patch set 7 08/07/12, 19:10

  24. Markus Klein commented on patch set 7 08/07/12, 19:10

    (1 inline comment)
  25. Markus Klein uploaded patch set 8 08/07/12, 19:10

  26. Stefan Galinski uploaded patch set 6 08/07/12, 19:10

  27. Stefan Galinski commented on patch set 6 08/07/12, 19:10

    (1 inline comment)
  28. Stefan Galinski commented on patch set 7 1 comment 08/07/12, 19:10

    Looks good to me, but someone else must approve Your changes seems to be fine. Thanks! :-)
  1. Markus Klein commented on patch set 9 08/07/12, 19:10

    Looks good to me, but someone else must approve
  2. Stefan Galinski uploaded patch set 9 08/07/12, 19:10

  3. Stefan Galinski commented on patch set 9 08/07/12, 19:10

    Regarding your changes (wasn't possible inline anymore): 1) Nice catch that you found out how to get rid of the sys_language where stuff. 2) Checked and didn't found a way to manage the language handling way you described. IMHO it's bug that content elements that are set to language -1 are not displayed if contentOL is set to 0. 3) Regarding your change in getRecordOverlay: I reverted this to my version, because of the following issue: Conditions: 1) Page with section index is only available in the default language 2) The section index shows the contents of a remote page. Results: Your version shows in this case the section index contents in the default language, also if the page was called in another language (and fallbacked to the default version). My version shows the section index contents in the requested language if possible and this is usually the wanted result in such a mixed environment. BTW: Furthermore the check in the condition prevents a useless call to getRecordOverlay if the default language version is requested or the remote page exists only in the default language. The usual behaviour in the core doesn't suits in all cases. :-)
  4. Stefan Galinski commented on patch set 9 08/07/12, 19:10

    Verified; Looks good to me, but someone else must approve About the new changeset: I reverted the getRecordOverlay behaviour (see comment before this one) and fixed the unit tests. Note that this change still contains a glitch. If you want to show the content of a page with different sys_language_contentOL settings it could break, but IMHO this is very unusual (and probably very buggy) that the handling changes inside the very same site.
  5. Christian Kuhn commented on patch set 2 08/07/12, 19:10

    I would prefer that you didn't submit this This is also a good chance to add unit tests to the method.
  6. Christian Kuhn commented on patch set 3 08/07/12, 19:10

    will test within the next 2 days.
  7. Anja Leichsenring commented on patch set 3 08/07/12, 19:10

    Verified; Looks good to me, but someone else must approve
  8. Mr. Jenkins commented on patch set 1 08/07/12, 19:10

  9. Mr. Jenkins commented on patch set 2 08/07/12, 19:10

  10. Mr. Jenkins commented on patch set 3 08/07/12, 19:10

  11. Mr. Jenkins commented on patch set 4 08/07/12, 19:10

  12. Mr. Jenkins commented on patch set 5 08/07/12, 19:10

  13. Mr. Jenkins commented on patch set 6 08/07/12, 19:10

  14. Mr. Jenkins commented on patch set 7 08/07/12, 19:10

  15. Mr. Jenkins commented on patch set 8 08/07/12, 19:10

  16. Mr. Jenkins commented on patch set 9 08/07/12, 19:10

  17. Wouter Wolters commented on patch set 1 08/07/12, 19:10

    Looks good to me, but someone else must approve
  18. Wouter Wolters commented on patch set 4 08/07/12, 19:10

    Verified; Looks good to me, but someone else must approve Verified with the unit-test
  19. Markus Klein commented on patch set 10 08/07/12, 19:10

    Looks good to me, but someone else must approve
  20. Stefan Galinski commented on patch set 10 08/07/12, 19:10

    Some core dev wants to give his final ok? The section index is still unusable in multilanguage environments without this patch since TYPO3 4.7.
  21. Mr. Jenkins commented on patch set 10 08/07/12, 19:10

  22. Wouter Wolters uploaded patch set 10 08/07/12, 19:10

  23. Wouter Wolters commented on patch set 10 08/07/12, 19:10

    Verified; Looks good to me, but someone else must approve Just added some CGL fixes to the latest patch. No functional change. Plz reapply votes.
  24. Christian Kuhn commented on patch set 10 V 0 08/07/12, 19:10

    by team member; Looks good to me, approved Nice! I'll merge this now and try to push the 4.7 version.
  25. Christian Kuhn merged patch set 10 08/07/12, 19:10