Review main Merged

11272[BUGFIX] Reduce CGL violations in class.tslib_fe.php

mostwanted CR +2 V +2 Hard +165 −165 updated 06/03/13, 20:49

Commit message

Fix/Reduce CGL violations "FunctionCallArgumentSpacingNoSpaceAfterComma"
in class.tslib_fe.php.

There are over 500 violations against this rule. This is fixed/reduced.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 1

Review log 6

  1. Oliver Klee commented on patch set 1 05/17/12, 17:33

    Looks good to me, but someone else must approve There still are lots of other CGL violations in the changed lines left, but this change is one little step towards better code.
  2. Christian Kuhn uploaded patch set 2 05/17/12, 17:33

  3. Mr. Jenkins commented on patch set 1 05/17/12, 17:33

  4. Mr. Jenkins commented on patch set 2 05/17/12, 17:33

  5. Christian Kuhn commented on patch set 2 V 0 05/17/12, 17:33

    by team member; Looks good to me, approved Just did some minor change to the commit message, other than that I'm fine and happy with the patch. Thanks!
  6. Christian Kuhn merged patch set 2 05/17/12, 17:33