11331[BUGFIX ] CGL violations FunctionCallArgumentSpacing in alt_doc.php
Commit message
Review
-
Code review CR +2
- Tolleiv Nietsch +2
- Oliver Klee +1
-
Verified V +2
- Tolleiv Nietsch +2
Issues 1
Files 1
Review log 11
-
mostwanted commented on patch set 1 05/25/12, 06:46
This fix was semi-automated in my IDE via regex search and manual replace. My IDE did not indicate any php errors. -
mostwanted uploaded patch set 2 05/25/12, 06:46
-
mostwanted commented on patch set 2 05/25/12, 06:46
OK, thanks for the tipp. -
Oliver Klee commented on patch set 3 05/25/12, 06:46
Looks good to me, but someone else must approve -
mostwanted uploaded patch set 3 05/25/12, 06:46
-
Christian Kuhn commented on patch set 1 05/25/12, 06:46
I would prefer that you didn't submit this Roland, please try not to use those abbreviations in the header line. Look at the recently merged patch, I've streamlined the header line a bit to get rid of them. -
Mr. Jenkins commented on patch set 1 05/25/12, 06:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4148/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/25/12, 06:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4152/ : SUCCESS -
Mr. Jenkins commented on patch set 3 05/25/12, 06:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4160/ : SUCCESS -
Tolleiv Nietsch commented on patch set 3 V 0 05/25/12, 06:46
by team member; Looks good to me, approved -
Tolleiv Nietsch merged patch set 3 05/25/12, 06:46