Review main Merged

11341[TASK] Clean up the phpDoc of t3lib_tceforms

Wouter Wolters CR +2 V +2 Expert +647 −570 updated 06/03/13, 20:49

Commit message

Clean up the phpDoc of t3lib_tceforms

So I made a patch doing mostly:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Review

  • Code review CR +2
    • Georg Ringer +2
    • Oliver Klee +1
  • Verified V +2
    • Georg Ringer +2
    • Oliver Klee +1

Issues 1

Files 1

Review log 24

  1. Gerrit wrote 05/30/12, 02:28

    Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review.
  2. Oliver Klee commented on patch set 1 05/30/12, 02:28

    (7 inline comments)

    class.t3lib_tceforms.php:1157

    Here, the parameter names still are missing.

    class.t3lib_tceforms.php:2928

    This is commented-out code that can be removed.

    class.t3lib_tceforms.php:4293

    missing parameter name

    class.t3lib_tceforms.php:4294

    missing parameter name

    class.t3lib_tceforms.php:4328

    An -> A

    class.t3lib_tceforms.php:4415

    missing parameter names

    class.t3lib_tceforms.php:5109

    missing parameter names

    class.t3lib_tceforms.php:6413

    tab -> space
  3. Mr. Jenkins commented on patch set 1 05/30/12, 02:28

  4. Oliver Klee commented on patch set 2 05/30/12, 02:28

    (1 inline comment)
  5. Mr. Jenkins commented on patch set 2 05/30/12, 02:28

  6. Wouter Wolters commented on patch set 2 05/30/12, 02:28

    Thank for the review Oliver:)
  7. Wouter Wolters uploaded patch set 2 05/30/12, 02:28

  8. Oliver Klee commented on patch set 3 05/30/12, 02:28

    Looks good to me, but someone else must approve
  9. Oliver Klee uploaded patch set 4 05/30/12, 02:28

  10. Oliver Klee commented on patch set 4 05/30/12, 02:28

    Looks good to me, but someone else must approve Just rebased.
  11. Oliver Klee uploaded patch set 5 05/30/12, 02:28

  12. Oliver Klee commented on patch set 5 05/30/12, 02:28

    Verified; Looks good to me, but someone else must approve Rebased to resolve merge conflicts. Tested with php -l.
  13. Georg Ringer commented on patch set 3 V 0 05/30/12, 02:28

    by team member; Looks good to me, approved
  14. Georg Ringer commented on patch set 3 05/30/12, 02:28

    wanna do the rebase?
  15. Georg Ringer commented on patch set 4 05/30/12, 02:28

    Verified; Looks good to me, but someone else must approve
  16. Mr. Jenkins commented on patch set 3 05/30/12, 02:28

  17. Mr. Jenkins commented on patch set 4 05/30/12, 02:28

  18. Mr. Jenkins commented on patch set 5 05/30/12, 02:28

  19. Wouter Wolters commented on patch set 3 05/30/12, 02:28

    Fix last inline comment.
  20. Wouter Wolters commented on patch set 3 05/30/12, 02:28

    Anyone?
  21. Wouter Wolters uploaded patch set 3 05/30/12, 02:28

  22. Wouter Wolters commented on patch set 3 05/30/12, 02:28

    Will rebase this today.
  23. Georg Ringer commented on patch set 5 V 0 05/30/12, 02:28

    by team member; Looks good to me, approved
  24. Georg Ringer merged patch set 5 05/30/12, 02:28