Review main Merged

1137[FEATURE] t3lib_DB: Turn off pconnect by default

Andreas Wolf CR +2 V +1 Easy +1 −1 updated 06/03/13, 20:49

Commit message

By default, TYPO3 uses *_pconnect() to connect to the database. This
is however only required in case connecting to the DB server is slow. In
other cases there is no advantage in turning this on, but there may be
disadvantages if the configuration of database and web server are not
aligned.
See also http://www.php.net/manual/en/features.persistent-connections.php

This commit was made based on a discussion on typo3-dev, see message
<mailman.12316.1298886389.648.typo3-dev@lists.typo3.org> and following.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Oliver Klee +1
    • Xavier Perseguers +1
  • Verified V +1
    • Mr. Jenkins +1
    • Xavier Perseguers +1

Files 1

Review log 7

  1. Andreas Wolf commented on patch set 1 03/12/11, 09:39

    Pushing after two +1s.
  2. Andreas Wolf commented on patch set 1 03/12/11, 09:39

    Looks good to me, approved Pushing after two +1s.
  3. Oliver Klee commented on patch set 1 03/12/11, 09:39

    Looks good to me, but someone else must approve
  4. Xavier Perseguers commented on patch set 1 03/12/11, 09:39

    Verified; Looks good to me, but someone else must approve A good step towards a clean 4.6!
  5. Mr. Jenkins commented on patch set 1 V 0 03/12/11, 09:39

  6. Mr. Jenkins commented on patch set 1 03/12/11, 09:39

  7. Andreas Wolf merged patch set 1 03/12/11, 09:39