Review main Merged

1142[FEATURE] Improve usability of group fields

Alexander Stehlik CR +2 V +2 Normal +51 −5 updated 06/03/13, 20:49

Commit message

If only one value is allowed in a group field (maxitems==1), the
present value will be removed when the user selects a new value via
element browser or file upload field.

If the list is disabled (by disable_controls setting) the user doesn't
have the possibility to remove items. To prevent a "write once" field
the first item in the list will be removed if the maxitems limit has
been reached.

Review

  • Code review CR +2
    • Steffen Kamper +2
    • Steffen Gebert +1
  • Verified V +2
    • Steffen Kamper +2
    • Steffen Gebert +1

Files 2

Review log 16

  1. Björn Pedersen commented on patch set 3 03/27/11, 10:33

    Looks good to me, but someone else must approve
  2. Steffen Kamper uploaded patch set 3 03/27/11, 10:33

  3. Steffen Kamper commented on patch set 3 03/27/11, 10:33

    Verified; Looks good to me, but someone else must approve @Alexander - good cazch and good patch! I uploaded a new version without the superfluous whitespaces. Works perfect, a good improvement!
  4. Steffen Kamper commented on patch set 4 03/27/11, 10:33

    Verified; Looks good to me, but someone else must approve
  5. Steffen Gebert commented on patch set 4 03/27/11, 10:33

    Verified; Looks good to me, but someone else must approve I've made some adjustments to the code formatting and comments. No functional changes. Nice addition, Alexander!
  6. Steffen Gebert uploaded patch set 4 03/27/11, 10:33

  7. Alexander Stehlik uploaded patch set 2 03/27/11, 10:33

  8. Mr. Jenkins commented on patch set 1 V 0 03/27/11, 10:33

  9. Mr. Jenkins commented on patch set 1 03/27/11, 10:33

  10. Mr. Jenkins commented on patch set 2 03/27/11, 10:33

  11. Mr. Jenkins commented on patch set 2 03/27/11, 10:33

  12. Mr. Jenkins commented on patch set 3 03/27/11, 10:33

  13. Mr. Jenkins commented on patch set 3 03/27/11, 10:33

  14. Mr. Jenkins commented on patch set 4 03/27/11, 10:33

  15. Steffen Kamper commented on patch set 4 V 0 03/27/11, 10:33

    by team member; Looks good to me, approved
  16. Steffen Kamper merged patch set 4 03/27/11, 10:33