Review main Merged

11634[TASK] Move t3lib_tcemain::getUniqueFields to EXT:version

Tolleiv Nietsch CR +2 V +2 Easy +2 −1 updated 06/03/13, 20:49

Commit message

The method is only used within EXT:version, therefore
it should be moved.

See related review in EXT:version: https://review.typo3.org/11632

Review

  • Code review CR +2
    • Jigal van Hemert +2
  • Verified V +2
    • Jigal van Hemert +2

Issues 1

Files 1

Review log 37

Show 12 earlier messages
  1. Tolleiv Nietsch uploaded patch set 2 04/24/13, 10:17

  2. Tolleiv Nietsch uploaded patch set 3 04/24/13, 10:17

  3. Tolleiv Nietsch commented on patch set 3 04/24/13, 10:17

    Well this functionality doesn't belong into t3lib_tcemain mainly because it doesn't add to the purpose of it. Therefore it should at least not be part of the public API of t3lib_tcemain. Due to the fact that this is used only once, my conclusion was that building up a new t3lib_utility_* for it would not make sense and that moving it away is the least thing to do. In general I can think of creating sth. like a t3lib_utiliy_tca class to collect such utility functions. But I see https://review.typo3.org/#/c/11635/ as prerequisite for that - and I guess it will take some time before that one gets properly tested and merged. Anyways this small part is just a small step towards cleaning up t3lib_tcemain (a bit) - the main "outcome" of it would be to remove it from t3lib_tcemain and search a better please for it later on.
  4. Oliver Klee commented on patch set 3 04/24/13, 10:17

    Looks good to me, but someone else must approve
  5. Helmut Hummel commented on patch set 3 04/24/13, 10:17

    I don't object this change in general, but I'm asking myself why it could be useful to do so. Even if getUniqueFields is only used in the version extension, unique fields are not bound to versioning and may have other usecases.
  6. Tolleiv Nietsch commented on patch set 4 04/24/13, 10:17

    I would prefer that you didn't submit this :( --- what's the point in deprecating it? Imho this method was not supposed to be used from the outside anyways - therefore the deprecation is imho not needed (see Core-list discussion)
  7. Stefan Neufeind commented on patch set 5 04/24/13, 10:17

    Looks good to me, but someone else must approve Change to EXT:version is now merged. Only used internally, so removing it (instead of deprecating) as was discussed already.
  8. Stefan Neufeind uploaded patch set 5 04/24/13, 10:17

  9. Stefan Neufeind uploaded patch set 6 04/24/13, 10:17

  10. Stefan Neufeind commented on patch set 6 04/24/13, 10:17

    hand-rebased fyi, the patch mentioned in commit-msg is already merged
  11. Stefan Neufeind commented on patch set 7 04/24/13, 10:17

    Looks good to me, but someone else must approve rebased. changed releases-line as suggested by Jigal. Still for 6.1 maybe?
  12. Stefan Neufeind uploaded patch set 7 04/24/13, 10:17

  1. Stefan Neufeind commented on patch set 7 04/24/13, 10:17

    referenced change in EXT:version is merged already
  2. Stefan Neufeind uploaded patch set 8 04/24/13, 10:17

  3. Stefan Neufeind uploaded patch set 9 04/24/13, 10:17

  4. Stefan Neufeind uploaded patch set 10 04/24/13, 10:17

  5. Benni Mack commented on patch set 7 V 0 04/24/13, 10:17

    by team member; Looks good to me, approved Cleanup, checked. Already in version since a long time.
  6. Oliver Klee commented on patch set 4 04/24/13, 10:17

    Looks good to me, but someone else must approve
  7. Helmut Hummel commented on patch set 4 04/24/13, 10:17

    Verified; Looks good to me, but someone else must approve
  8. Christian Kuhn commented on patch set 4 04/24/13, 10:17

    Verified; Looks good to me, but someone else must approve Lets deprecate the method instead of removing it directly, see new patch. What do you think?
  9. Christian Kuhn commented on patch set 4 04/24/13, 10:17

    Until now, we never just removed any method that was part of a public API until then. What speaks against deprecating in this special case as we are used to do?
  10. Christian Kuhn uploaded patch set 4 04/24/13, 10:17

  11. Georg Ringer commented on patch set 3 04/24/13, 10:17

    Verified; Looks good to me, but someone else must approve
  12. Jigal van Hemert commented on patch set 6 04/24/13, 10:17

    I would prefer that you didn't submit this We really need to deprecate the original function before removing it later on. We can't really know that nobody uses it.
    Releases: 6.1 as it's a change in the API.
  13. Jigal van Hemert commented on patch set 6 04/24/13, 10:17

    (1 inline comment)
  14. Mr. Jenkins commented on patch set 1 04/24/13, 10:17

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4218/ : FAILURE
  15. Mr. Jenkins commented on patch set 2 04/24/13, 10:17

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4220/ : FAILURE
  16. Mr. Jenkins commented on patch set 3 04/24/13, 10:17

  17. Mr. Jenkins commented on patch set 4 04/24/13, 10:17

  18. Mr. Jenkins commented on patch set 5 04/24/13, 10:17

  19. Mr. Jenkins commented on patch set 6 04/24/13, 10:17

  20. Mr. Jenkins commented on patch set 7 04/24/13, 10:17

  21. Mr. Jenkins commented on patch set 8 04/24/13, 10:17

  22. Mr. Jenkins commented on patch set 10 04/24/13, 10:17

  23. Wouter Wolters commented on patch set 3 04/24/13, 10:17

    Looks good to me, but someone else must approve
  24. Jigal van Hemert commented on patch set 10 V 0 04/24/13, 10:17

    by team member; Looks good to me, approved Merged as no-brainer
  25. Jigal van Hemert merged patch set 11 04/24/13, 10:17