11639[BUGFIX ] CGL violations FunctionCallArgumentSpacing in /typo3/sysext/cms/
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Oliver Klee +1
- Wouter Wolters +1
-
Verified V +2
- Georg Ringer +2
- Oliver Klee +1
- Wouter Wolters +1
Issues 1
Files 31
- typo3/sysext/cms/layout/db_layout.php+41 −41
- typo3/sysext/cms/layout/db_new_content_el.php+14 −14
- typo3/sysext/cms/tslib/content/class.tslib_content_content.php+1 −1
- typo3/sysext/cms/tslib/content/class.tslib_content_contenttable.php+9 −9
- typo3/sysext/cms/tslib/content/class.tslib_content_flowplayer.php+1 −1
- typo3/sysext/cms/tslib/content/class.tslib_content_form.php+1 −1
- typo3/sysext/cms/tslib/media/scripts/example_callfunction.php+7 −7
- typo3/sysext/cms/tslib/media/scripts/example_itemArrayProcFunc.php+3 −3
- typo3/sysext/cms/tslib/media/scripts/example_keepRollover.php+1 −1
- typo3/sysext/cms/tslib/media/scripts/example_languageMenu.php+1 −1
- typo3/sysext/cms/tslib/media/scripts/example_typolinkpop.php+1 −1
- typo3/sysext/cms/tslib/media/scripts/gmenu_foldout.php+7 −7
- typo3/sysext/cms/tslib/media/scripts/gmenu_layers.php+25 −25
- typo3/sysext/cms/tslib/media/scripts/testscript_EXT.php+2 −2
- typo3/sysext/cms/tslib/media/scripts/tmenu_layers.php+27 −27
- typo3/sysext/cms/tslib/class.tslib_adminpanel.php+2 −2
- typo3/sysext/cms/tslib/class.tslib_content.php+5 −5
- typo3/sysext/cms/tslib/class.tslib_fe.php+1 −1
- typo3/sysext/cms/tslib/class.tslib_feuserauth.php+7 −7
- typo3/sysext/cms/tslib/class.tslib_gifbuilder.php+34 −34
Show 11 more files
- typo3/sysext/cms/tslib/class.tslib_menu.php+187 −187
- typo3/sysext/cms/tslib/class.tslib_pagegen.php+13 −13
- typo3/sysext/cms/tslib/class.tslib_pibase.php+81 −81
- typo3/sysext/cms/tslib/class.tslib_search.php+22 −22
- typo3/sysext/cms/tslib/index_ts.php+10 −10
- typo3/sysext/cms/tslib/showpic.php+5 −5
- typo3/sysext/cms/web_info/class.tx_cms_webinfo.php+10 −10
- typo3/sysext/cms/web_info/class.tx_cms_webinfo_lang.php+25 −25
- typo3/sysext/cms/ext_tables.php+3 −3
- typo3/sysext/cms/tbl_cms.php+4 −4
- typo3/sysext/cms/tbl_tt_content.php+1 −1
Review log 10
-
Oliver Klee commented on patch set 1 06/01/12, 06:35
Looks good to me, but someone else must approve -
Oliver Klee uploaded patch set 2 06/01/12, 06:35
-
Oliver Klee commented on patch set 2 06/01/12, 06:35
Verified; Looks good to me, but someone else must approve Rebased to fix some merge conflicts. Tested by running the cms and Core unit tests and by viewing the start page of my local TYPO3 installation. -
mostwanted commented on patch set 1 06/01/12, 06:35
This fix was semi-automated in my IDE via regex search and manual replace. My IDE did not indicate any php errors. -
Mr. Jenkins commented on patch set 1 06/01/12, 06:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4231/ : SUCCESS -
Mr. Jenkins commented on patch set 2 06/01/12, 06:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4250/ : SUCCESS -
Wouter Wolters commented on patch set 1 06/01/12, 06:35
Looks good to me, but someone else must approve Nice! -
Wouter Wolters commented on patch set 2 06/01/12, 06:35
Verified; Looks good to me, but someone else must approve Unit-tests running fine. -
Georg Ringer commented on patch set 2 V 0 06/01/12, 06:35
by team member; Looks good to me, approved -
Georg Ringer merged patch set 2 06/01/12, 06:35