11769[TASK] CGL violations FunctionCallArgumentSpacing in /typo3/sysext/s*/
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Wouter Wolters +1
-
Verified V +2
- Georg Ringer +2
Issues 1
Files 6
Review log 9
-
mostwanted commented on patch set 1 06/01/12, 13:54
This fix was semi-automated in my IDE via regex search and manual replace. My IDE did not indicate any php errors. -
mostwanted uploaded patch set 2 06/01/12, 13:54
-
mostwanted commented on patch set 2 06/01/12, 13:54
thanks for the hint. i only touched class.tx_sv_auth.php. -
Mr. Jenkins commented on patch set 1 06/01/12, 13:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4284/ : SUCCESS -
Mr. Jenkins commented on patch set 2 06/01/12, 13:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4294/ : SUCCESS -
Wouter Wolters commented on patch set 1 06/01/12, 13:54
(2 inline comments) See my commentsclass.tx_sv_auth.php:180space are missingclass.tx_sv_auth.php:196spaces are missing -
Wouter Wolters commented on patch set 2 06/01/12, 13:54
Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 2 V 0 06/01/12, 13:54
by team member; Looks good to me, approved -
Georg Ringer merged patch set 2 06/01/12, 13:54