Review main Merged

11789[FEATURE] Redesign of sys_note

Georg Ringer CR +2 V +2 Hard +384 −150 updated 06/03/13, 20:49

Commit message

Complete redesign of the sys_notes

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 20

Review log 38

Show 13 earlier messages
  1. Georg Ringer commented on patch set 1 06/30/12, 11:33

    (1 inline comment) cleanup will come next days

    class.db_list.inc:349

    yeah i know...
  2. Georg Ringer uploaded patch set 2 06/30/12, 11:33

  3. Georg Ringer commented on patch set 2 06/30/12, 11:33

    Do not submit a damn changes ;)
  4. Georg Ringer uploaded patch set 3 06/30/12, 11:33

  5. Georg Ringer commented on patch set 4 06/30/12, 11:33

    (1 inline comment) still the CGL fixes there, those shouldn't be in the diff or?
  6. Soren Malling uploaded patch set 4 06/30/12, 11:33

  7. Soren Malling commented on patch set 4 06/30/12, 11:33

    (1 inline comment)
  8. Soren Malling commented on patch set 4 06/30/12, 11:33

    (1 inline comment)
  9. Christian Kuhn commented on patch set 5 06/30/12, 11:33

    The comment indention changes typo3/sysext/cms/layout/db_layout.php should be reverted, rule is, that inline comments are indented with one tab
  10. Soren Malling uploaded patch set 5 06/30/12, 11:33

  11. Philipp Gampe commented on patch set 4 06/30/12, 11:33

    (1 inline comment)
  12. Felix Kopp commented on patch set 5 06/30/12, 11:33

    (4 inline comments) Looks really mature, like the approach to move into separate ext and hook into page/list. But what makes me curious are all the inline comments in db_list and SC. The inline comments in core were just shifted on tab to the right. Why do you unshift these? Please see recent "Fix CGL violations against InlineCommentWrongStyle" commits. Shall I upload a commit for CSS and formal nit-picking mentions. What are your positions concerning the inline comments.
  13. Mr. Jenkins commented on patch set 1 06/30/12, 11:33

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4296/ : FAILURE
  1. Mr. Jenkins commented on patch set 2 06/30/12, 11:33

  2. Mr. Jenkins commented on patch set 3 06/30/12, 11:33

  3. Mr. Jenkins commented on patch set 4 06/30/12, 11:33

  4. Mr. Jenkins commented on patch set 5 06/30/12, 11:33

  5. Wouter Wolters commented on patch set 3 06/30/12, 11:33

    (1 inline comment)

    class.db_list.inc:5

    Kasper's last name isn't right.
  6. Wouter Wolters commented on patch set 5 06/30/12, 11:33

    typo3/class.db_list.inc needs to be rebased:) See https://review.typo3.org/#/c/11966/
  7. Mr. Jenkins commented on patch set 6 06/30/12, 11:33

  8. Wouter Wolters uploaded patch set 6 06/30/12, 11:33

  9. Wouter Wolters commented on patch set 6 06/30/12, 11:33

    Rebase is wrond. Will push a new version.
  10. Mr. Jenkins commented on patch set 7 06/30/12, 11:33

  11. Wouter Wolters uploaded patch set 7 06/30/12, 11:33

  12. Mr. Jenkins commented on patch set 8 06/30/12, 11:33

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4541/ : FAILURE
  13. Wouter Wolters uploaded patch set 8 06/30/12, 11:33

  14. Wouter Wolters commented on patch set 8 06/30/12, 11:33

    Finally rebased:D Will check soon again myself.
  15. Helmut Hummel commented on patch set 9 06/30/12, 11:33

    (2 inline comments) Not sure. Better than before though...
  16. Christian Kuhn commented on patch set 9 06/30/12, 11:33

    (2 inline comments)
  17. Christian Kuhn uploaded patch set 10 06/30/12, 11:33

  18. Christian Kuhn commented on patch set 10 06/30/12, 11:33

    Verified; Looks good to me, but someone else must approve Sorry for the long delay! New version just solves a conflict in db_list, and deprecates the (empty) method instead of removing directly. We should imho let this patch in, any other refactorings (like switching to fluid template) can be done with additional patches. For now, the code is separated and the module is much cooler than before. I would love to see more improvements in this area (for example a way to add nots from the page module directly, instead of list->new record). +1, lets get this done :)
  19. Georg Ringer commented on patch set 9 06/30/12, 11:33

    (2 inline comments)
  20. Mr. Jenkins commented on patch set 9 06/30/12, 11:33

  21. Mr. Jenkins commented on patch set 10 06/30/12, 11:33

  22. Wouter Wolters uploaded patch set 9 06/30/12, 11:33

  23. Wouter Wolters commented on patch set 10 06/30/12, 11:33

    Verified; Looks good to me, but someone else must approve
  24. Christian Kuhn commented on patch set 10 V 0 06/30/12, 11:33

    by team member; Looks good to me, approved
  25. Christian Kuhn merged patch set 10 06/30/12, 11:33