Review main Merged

11840[BUGFIX] Remove class of td if "No CSS styles for this table" is set

Juergen Furrer CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Files 1

Review log 16

  1. Philipp Gampe commented on patch set 1 06/30/12, 11:33

    I would prefer that you didn't submit this otherwise change looks ok
    The second line must be empty! Always! This is a common git rule.
  2. Philipp Gampe uploaded patch set 2 06/30/12, 11:33

  3. Philipp Gampe uploaded patch set 3 06/30/12, 11:33

  4. Philipp Gampe commented on patch set 3 06/30/12, 11:33

    Looks good to me, but someone else must approve I fixed the release message and added 6.0 to the releases line.
  5. Mr. Jenkins commented on patch set 1 06/30/12, 11:33

  6. Mr. Jenkins commented on patch set 2 06/30/12, 11:33

  7. Mr. Jenkins commented on patch set 3 06/30/12, 11:33

  8. Christian Kuhn uploaded patch set 5 06/30/12, 11:33

  9. Christian Kuhn commented on patch set 5 06/30/12, 11:33

    Verified; Looks good to me, but someone else must approve How to test: Just add a content element table, add a row, set checkbox -> class still rendered. Apply patch -> class not rendered with checkbox set, class rendered with checkbox set.
  10. Mr. Jenkins commented on patch set 4 06/30/12, 11:33

  11. Mr. Jenkins commented on patch set 5 06/30/12, 11:33

  12. Wouter Wolters uploaded patch set 4 06/30/12, 11:33

  13. Wouter Wolters commented on patch set 4 06/30/12, 11:33

    Verified; Looks good to me, but someone else must approve Rebased and small CGL cleanup
  14. Wouter Wolters commented on patch set 5 06/30/12, 11:33

    Verified; Looks good to me, but someone else must approve
  15. Christian Kuhn commented on patch set 5 V 0 06/30/12, 11:33

    by team member; Looks good to me, approved
  16. Christian Kuhn merged patch set 5 06/30/12, 11:33