Review main Merged

11859[BUGFIX] TSFE->additionalFooterData for USER_INT

Oliver Hader CR +2 V +2 Normal +114 −3 updated 06/03/13, 20:49

Commit message

TSFE->additionalFooterData was introduced with TYPO3 4.3, but
only for the purpose of t3lib_PageRenderer. The definition of
this property is e.g. missing at all in tslib_fe and besides
that, the handling for USER_INT/COA_INT objects is not there
at all.

Review

  • Code review CR +2
    • Helmut Hummel +2
  • Verified V +2
    • Helmut Hummel +2

Files 4

Review log 22

  1. Stefan Neufeind commented on patch set 1 06/29/12, 18:34

    Looks good to me, but someone else must approve The CGL-remarks etc. are fine. But the rest seems to make sense by reading. Actually it's "just" for footerData what we already have in there for HeaderData already. Having testcases would be nice. But we don't have any testcase for pagegen at all currently. I briefly looked into it and I'm not sure how large that "build a proper mock"-thing might grow (synthesizing all needed TS-config etc. for a minimal page-setup). Current dev-checkout doesn't run here for some reason :-( Need to solve that before I could trying to come up with a testcase.
  2. Oliver Klee commented on patch set 1 06/29/12, 18:34

    (1 inline comment) Having this covered by unit tests would be great.
  3. Oliver Klee commented on patch set 1 06/29/12, 18:34

    I'd just add (regression) tests for this bug: For each of the two classes, put something in the field and check whether it appears in the generated output.
  4. Oliver Hader commented on patch set 1 06/29/12, 18:34

    (2 inline comments)
  5. Oliver Hader commented on patch set 1 06/29/12, 18:34

    (1 inline comment) @Olli: UnitTests would be cool, however this one affects the whole frontend rendering process, do you have any suggestions?
  6. Philipp Gampe commented on patch set 1 06/29/12, 18:34

    (3 inline comments)

    class.tslib_fe.php:136

    For new stuff, it would be cool if you could change the comment to a PHPdoc header.

    class.tslib_fe.php:3028

    So this should have been remove for 6.0? Or first announce the removal for 6.2?

    class.tslib_fe.php:3048

    CGL: space around . (dot)
  7. Mr. Jenkins commented on patch set 1 06/29/12, 18:34

  8. Stefan Neufeind commented on patch set 2 06/29/12, 18:34

    Looks good to me, but someone else must approve
  9. Helmut Hummel uploaded patch set 3 06/29/12, 18:34

  10. Helmut Hummel commented on patch set 4 06/29/12, 18:34

    (2 inline comments)
  11. Helmut Hummel uploaded patch set 4 06/29/12, 18:34

  12. Helmut Hummel commented on patch set 4 06/29/12, 18:34

    Verified; Looks good to me, but someone else must approve Added a test that mimics USER_INT rendering and checks if both header and footer data is replaced
  13. Helmut Hummel uploaded patch set 5 06/29/12, 18:34

  14. Helmut Hummel commented on patch set 5 V 0 06/29/12, 18:34

    by team member; Looks good to me, approved Merging this now, taking the positive votes of the other changesets into account. Nothing has changed code-wise, only rebase happened and unit tests were added
  15. Georg Ringer commented on patch set 4 2 comments 06/29/12, 18:34

    Looks good to me, but someone else must approve
  16. Mr. Jenkins commented on patch set 2 06/29/12, 18:34

  17. Mr. Jenkins commented on patch set 3 06/29/12, 18:34

  18. Mr. Jenkins commented on patch set 4 06/29/12, 18:34

  19. Mr. Jenkins commented on patch set 5 06/29/12, 18:34

  20. Wouter Wolters uploaded patch set 2 06/29/12, 18:34

  21. Wouter Wolters commented on patch set 2 06/29/12, 18:34

    Looks good to me, but someone else must approve Rebased
  22. Helmut Hummel merged patch set 5 06/29/12, 18:34