11924[TASK] CGL FunctionCallArgumentSpacingNoSpaceAfterComma in saltedpasswords
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Oliver Klee +1
-
Verified V +2
- Christian Kuhn +2
Issues 1
Files 5
- typo3/sysext/saltedpasswords/classes/salts/class.tx_saltedpasswords_salts_blowfish.php+1 −1
- typo3/sysext/saltedpasswords/classes/salts/class.tx_saltedpasswords_salts_md5.php+2 −2
- typo3/sysext/saltedpasswords/classes/salts/class.tx_saltedpasswords_salts_phpass.php+1 −1
- typo3/sysext/saltedpasswords/classes/class.tx_saltedpasswords_emconfhelper.php+1 −1
- typo3/sysext/saltedpasswords/sv1/class.tx_saltedpasswords_sv1.php+1 −1
Review log 5
-
Oliver Klee commented on patch set 1 06/11/12, 17:05
Looks good to me, but someone else must approve -
mostwanted commented on patch set 1 06/11/12, 17:05
This fix was semi-automated in my IDE via regex search and manual replace. My IDE did not indicate any php errors. -
Mr. Jenkins commented on patch set 1 06/11/12, 17:05
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4349/ : SUCCESS -
Christian Kuhn commented on patch set 1 V 0 06/11/12, 17:05
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 1 06/11/12, 17:05