Review main Merged

11928[BUGFIX] No version overlay should be done for sys_language

Lienhart Woitok CR +2 V +2 Easy +4 −2 updated 08/20/13, 21:02

Commit message

The tables sys_language and static_languages do not support
versioning. Therefore, when doing a version preview, no
version overlay should be applied to them.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Files 1

Review log 24

  1. Stefan Neufeind commented on patch set 2 05/27/13, 17:19

    Looks good to me, but someone else must approve Hmm, how come I didn't notice that SQL-error until now?
  2. Stefan Neufeind uploaded patch set 3 05/27/13, 17:19

  3. Stefan Neufeind commented on patch set 3 05/27/13, 17:19

    hand-rebased had 3x +1-by-review
  4. Lienhart Woitok uploaded patch set 2 05/27/13, 17:19

  5. Philipp Gampe commented on patch set 1 05/27/13, 17:19

    Looks good to me, but someone else must approve It is common to have the change-id line on top of Fixes, but it does not matter.

    class.tslib_fe.php:2349

    the comment is rather long, please split it
  6. Philipp Gampe commented on patch set 1 05/27/13, 17:19

    (1 inline comment) btw, Mr. Jenkens seems to be wrong today.
  7. Philipp Gampe commented on patch set 2 05/27/13, 17:19

    Looks good to me, but someone else must approve
  8. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4350/ : FAILURE
  9. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  10. Mr. Jenkins commented on patch set 3 05/27/13, 17:19

  11. Wouter Wolters commented on patch set 2 05/27/13, 17:19

    Looks good to me, but someone else must approve
  12. Wouter Wolters uploaded patch set 4 05/28/13, 18:53

  13. Mr. Jenkins commented on patch set 4 05/28/13, 18:54

  14. Wouter Wolters voted on patch set 4 CR +1 07/29/13, 13:52

  15. Stefan Neufeind voted on patch set 4 CR +1 08/05/13, 20:33

  16. Stefan Galinski voted on patch set 4 V +1 08/08/13, 18:59

  17. Christian Kuhn updated the commit message in patch set 4 08/08/13, 19:42

  18. Mr. Jenkins commented on patch set 5 08/08/13, 19:42

  19. Christian Kuhn commented on patch set 5 V +1 CR +1 08/08/13, 19:43

    In general, this is only a workaround. The problem begins with the fact that this piece of code is dedicated to a specific extension (non-core) that is also not abstracted. I'd accept the workaround for now, though.
  20. Stefan Neufeind voted on patch set 5 CR +1 08/09/13, 10:07

  21. Wouter Wolters voted on patch set 5 V +2 CR +2 08/20/13, 21:01

  22. Wouter Wolters merged patch set 6 08/20/13, 21:01

  23. Wouter Wolters commented on patch set 6 08/20/13, 21:02

    Cherry Picked This patchset was cherry picked to change: I37be782601fc37e78a74d2459b6f246c5107b701
  24. Wouter Wolters commented on patch set 6 08/20/13, 21:02

    Cherry Picked This patchset was cherry picked to change: I37be782601fc37e78a74d2459b6f246c5107b701