Review main Merged

11978[BUGFIX] Correctly append additionalTreelistUpdateFields

Bart Dubelaar CR +2 V +2 Easy +1 −1 updated 11/11/13, 18:29

Commit message

The list of additionalTreelistUpdateFields was not correctly
appended to the updateRequiringFields array.

Review

  • Code review CR +2
    • Stefan Neufeind +2
  • Verified V +2
    • Stefan Neufeind +2

Issues 1

Files 1

Review log 17

  1. Stefan Neufeind commented on patch set 1 05/27/13, 17:19

    Looks good to me, but someone else must approve no-brainer?
  2. Stefan Neufeind uploaded patch set 2 05/27/13, 17:19

  3. Stefan Neufeind commented on patch set 2 05/27/13, 17:19

    hand-rebased had 2x review
  4. Philipp Gampe commented on patch set 1 05/27/13, 17:19

    Looks good to me, but someone else must approve
  5. Bart Dubelaar commented on patch set 2 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  7. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  8. Stefan Neufeind updated the commit message in patch set 2 11/11/13, 18:09

  9. Gerrit wrote 11/11/13, 18:10

    The change could not be merged due to a path conflict. Please rebase the change locally and upload the rebased commit for review.
  10. Stefan Neufeind commented on patch set 3 V +2 CR +2 11/11/13, 18:10

    Adjusted releases-line. It's obvious from code and comment what is the expected behaviour. += just does not work on arrays :-)
  11. Stefan Neufeind uploaded patch set 4 11/11/13, 18:11

  12. Stefan Neufeind commented on patch set 4 V +2 CR +2 11/11/13, 18:12

    needed to rebase locally. Votes still apply. Easy/obvious fix.
  13. Stefan Neufeind merged patch set 5 11/11/13, 18:12

  14. Stefan Neufeind commented on patch set 5 11/11/13, 18:12

    Cherry Picked This patchset was cherry picked to change: I7df514649203bf607a6ac3550c875c429e0f7328
  15. Stefan Neufeind commented on patch set 5 11/11/13, 18:12

    Cherry Picked This patchset was cherry picked to change: I7df514649203bf607a6ac3550c875c429e0f7328
  16. Mr. Jenkins commented on patch set 3 11/11/13, 18:27

  17. Mr. Jenkins commented on patch set 4 11/11/13, 18:29