Review main Merged

12010[TASK] Clean up phpDoc comments in typo3/

Wouter Wolters CR +2 V +2 Expert +642 −711 updated 06/03/13, 20:49

Commit message

Clean up phpDoc comments for the following classes:

* typo3/view_help.php
* typo3/wizard_colorpicker.php
* typo3/wizard_edit.php
* typo3/wizard_forms.php
* typo3/wizard_list.php
* typo3/wizard_rte.php
* typo3/wizard_table.php
* typo3/wizard_tsconfig.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 8

Review log 10

  1. Oliver Klee commented on patch set 1 06/14/12, 21:38

    I would prefer that you didn't submit this

    wizard_table.php:592

    2 missing parameter names

    wizard_tsconfig.php:537

    objTree -> str
  2. Mr. Jenkins commented on patch set 1 06/14/12, 21:38

  3. Oliver Klee commented on patch set 2 06/14/12, 21:38

    Looks good to me, but someone else must approve
  4. Christian Kuhn commented on patch set 3 V 0 06/14/12, 21:38

    by team member; Looks good to me, approved
  5. Christian Kuhn uploaded patch set 3 06/14/12, 21:38

  6. Mr. Jenkins commented on patch set 2 06/14/12, 21:38

  7. Mr. Jenkins commented on patch set 3 06/14/12, 21:38

  8. Wouter Wolters uploaded patch set 2 06/14/12, 21:38

  9. Wouter Wolters commented on patch set 2 06/14/12, 21:38

    Thanks Oliver for you're reviews:-) Fixed the comments you mentioned.
  10. Christian Kuhn merged patch set 3 06/14/12, 21:38