Review main Merged

12153[TASK] Clean up phpDoc comments in typo3/sysext/

Wouter Wolters CR +2 V +2 Expert +695 −677 updated 06/03/13, 20:49

Commit message

Clean up phpDoc comments for the following classes:

* typo3/sysext/cms/tslib/class.tslib_fe.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 1

Review log 8

  1. Oliver Klee commented on patch set 1 06/20/12, 20:43

    I would prefer that you didn't submit this

    class.tslib_fe.php:1135

    missing parameter names

    class.tslib_fe.php:1658

    missing parameter name

    class.tslib_fe.php:2910

    missing parameter name

    class.tslib_fe.php:4433

    missing parameter name
  2. Mr. Jenkins commented on patch set 1 06/20/12, 20:43

  3. Oliver Klee commented on patch set 2 06/20/12, 20:43

    Looks good to me, but someone else must approve
  4. Mr. Jenkins commented on patch set 2 06/20/12, 20:43

  5. Wouter Wolters commented on patch set 2 06/20/12, 20:43

    Fixed the inline comments.
  6. Wouter Wolters uploaded patch set 2 06/20/12, 20:43

  7. Christian Kuhn commented on patch set 2 V 0 06/20/12, 20:43

    by team member; Looks good to me, approved
  8. Christian Kuhn merged patch set 2 06/20/12, 20:43