1216[BUGFIX] link title with wrong encoded umlauts
Commit message
Review
-
Code review CR +2
- Steffen Kamper +2
- Helmut Hummel +1
-
Verified V +1
- Steffen Kamper +1
- Helmut Hummel +1
Files 1
Review log 6
-
Steffen Gebert commented on patch set 1 03/21/11, 21:54
Thanks for your patch, Frederic! Could you please push this change to the master branch, too? We must ensure that it gets fixed in 4.5, but stays open in master (->4.6). We're currently elaborating, what a commit message should include and how it should be written. For the moment: Please do not describe, what the current problem is (which you aim to fix), but describe what you are changing, e.g. Use Ext.urlEncode() to encode links in TBE_EDITOR. This ensures correct generation of strings in conjunction with UTF-8 and fixes wrongly encoded special chars (e.g. umlauts) in the browse-links dialog's field link-title. Just a suggestion.. because your commit messaged will directly go to the git history, we try to force a bit more strict rules now. You can re-submit the change by amending the commit: commit --amend and pushing again (but leave the Change-Id in the commit message!) -
Helmut Hummel commented on patch set 2 03/21/11, 21:54
Verified; Looks good to me, but someone else must approve This one should also go into 4.4 branch -
Frederic Gaus commented on patch set 2 03/21/11, 21:54
Thanks for your feedback. I changed this description and applied a new RFC for branch "master". I hope this was right because I didn't find a way to change the branch of my RFC. If I was right, should I provide another RFC for branch 4.4? If I was wrong, how do I do it right? -
Frederic Gaus uploaded patch set 2 03/21/11, 21:54
-
Steffen Kamper commented on patch set 2 03/21/11, 21:54
Verified; Looks good to me, approved -
Steffen Kamper merged patch set 2 03/21/11, 21:54