Review main Merged

12258[TASK] Fix CGL violations against DoubleQuoteUsage

Ludwig Rafelsberger CR +2 V +2 Normal +48 −49 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Helmut Hummel +2
    • Oliver Klee +1
  • Verified V +2
    • Helmut Hummel +2
    • Steffen Ritter +1

Issues 1

Files 1

Review log 13

  1. Helmut Hummel merged patch set 1 06/21/12, 20:27

  2. Oliver Klee uploaded patch set 2 06/21/12, 20:27

  3. Oliver Klee uploaded patch set 3 06/21/12, 20:27

  4. Oliver Klee uploaded patch set 4 06/21/12, 20:27

  5. Oliver Klee commented on patch set 4 06/21/12, 20:27

    Looks good to me, but someone else must approve Changed to use the LF constant. Also added the "Resolves" and "Releases" lines to the commit message.
  6. mostwanted commented on patch set 1 06/21/12, 20:27

    (1 inline comment) small improvement hint in inline comment - otherwise looks good.

    class.tx_em_tools_unzip.php:126

    You could use single quotes here too and escape the already used ones like you did in line 124.
  7. mostwanted commented on patch set 4 06/21/12, 20:27

    (1 inline comment)
  8. Helmut Hummel commented on patch set 4 V 0 06/21/12, 20:27

    by team member; Looks good to me, approved
  9. Steffen Ritter commented on patch set 1 06/21/12, 20:27

    Looks good to me, but someone else must approve additionally I have even one improvement more to that

    class.tx_em_tools_unzip.php:124

    what about LN constant

    class.tx_em_tools_unzip.php:126

    Constant could be used here, too
  10. Steffen Ritter commented on patch set 4 06/21/12, 20:27

    Verified; Looks good to me, but someone else must approve
  11. Steffen Ritter commented on patch set 4 06/21/12, 20:27

    Looks good to me, approved
  12. Wouter Wolters commented on patch set 1 06/21/12, 20:27

    Looks good to me, but someone else must approve
  13. Oliver Klee commented on patch set 4 06/21/12, 20:27

    (1 inline comment)