12258[TASK] Fix CGL violations against DoubleQuoteUsage
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
- Helmut Hummel +2
- Oliver Klee +1
-
Verified V +2
- Helmut Hummel +2
- Steffen Ritter +1
Issues 1
Files 1
Review log 13
-
Helmut Hummel merged patch set 1 06/21/12, 20:27
-
Oliver Klee uploaded patch set 2 06/21/12, 20:27
-
Oliver Klee uploaded patch set 3 06/21/12, 20:27
-
Oliver Klee uploaded patch set 4 06/21/12, 20:27
-
Oliver Klee commented on patch set 4 06/21/12, 20:27
Looks good to me, but someone else must approve Changed to use the LF constant. Also added the "Resolves" and "Releases" lines to the commit message. -
mostwanted commented on patch set 1 06/21/12, 20:27
(1 inline comment) small improvement hint in inline comment - otherwise looks good.class.tx_em_tools_unzip.php:126You could use single quotes here too and escape the already used ones like you did in line 124. -
mostwanted commented on patch set 4 06/21/12, 20:27
(1 inline comment) -
Helmut Hummel commented on patch set 4 V 0 06/21/12, 20:27
by team member; Looks good to me, approved -
Steffen Ritter commented on patch set 1 06/21/12, 20:27
Looks good to me, but someone else must approve additionally I have even one improvement more to thatclass.tx_em_tools_unzip.php:124what about LN constantclass.tx_em_tools_unzip.php:126Constant could be used here, too -
Steffen Ritter commented on patch set 4 06/21/12, 20:27
Verified; Looks good to me, but someone else must approve -
Steffen Ritter commented on patch set 4 06/21/12, 20:27
Looks good to me, approved -
Wouter Wolters commented on patch set 1 06/21/12, 20:27
Looks good to me, but someone else must approve -
Oliver Klee commented on patch set 4 06/21/12, 20:27
(1 inline comment)