12713BUGFIX] strftime expects parameter 2 to be long, string given
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Stefan Neufeind +1
- Marcus Schwemer +1
-
Verified V +2
- Jigal van Hemert +2
- Marcus Schwemer +1
Files 1
Review log 19
-
Mario Rimann commented on patch set 1 09/18/12, 19:54
(1 inline comment)class.tslib_content.php:2551I guess this will work - but I find it rather complicated to read/understand. -
Marcus Schwemer commented on patch set 1 09/18/12, 19:54
Looks good to me, but someone else must approve -
Marcus Schwemer voted on patch set 1 V 0 09/18/12, 19:54
-
Stefan Neufeind commented on patch set 2 09/18/12, 19:54
Looks good to me, but someone else must approvenitpick: Bracket missing before BUGFIX. (Not sure if that might affect automatic parsing of changelog etc.) -
Marcus Schwemer commented on patch set 2 09/18/12, 19:54
Verified; Looks good to me, but someone else must approve -
Jigal van Hemert commented on patch set 2 09/18/12, 19:54
@Simon Do you have time for backports. I can merge them. -
Jigal van Hemert commented on patch set 2 09/18/12, 19:54
Adapted for the namespace situation. Still valid votes from version 1: +1 Verified: 2 +1 Looks good.. : 3 Needs review from core team member. -
Jigal van Hemert commented on patch set 2 V 0 09/18/12, 19:54
by team member; Looks good to me, approved -
Jigal van Hemert uploaded patch set 2 09/18/12, 19:54
-
Jigal van Hemert merged patch set 2 09/18/12, 19:54
-
Simon Schaufelberger commented on patch set 1 09/18/12, 19:54
hi mario, this is the same patch applied to the date function after a long discussion. -
Simon Schaufelberger commented on patch set 1 09/18/12, 19:54
Verified; Looks good to me, but someone else must approve -
Simon Schaufelberger commented on patch set 1 09/18/12, 19:54
common guys, please merge that one. it has already been solved for the date function and this is just the same fix for the strftime function. -
Simon Schaufelberger commented on patch set 2 09/18/12, 19:54
finally!!! wow, that took really a looooooong time... PS: the commit message is broken. the missing "[" was not added. -
Simon Schaufelberger commented on patch set 2 09/18/12, 19:54
yes, i have. -
Mr. Jenkins commented on patch set 1 09/18/12, 19:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4837/ : SUCCESS -
Mr. Jenkins commented on patch set 2 09/18/12, 19:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5728/ : SUCCESS -
Wouter Wolters commented on patch set 1 09/18/12, 19:54
Looks good to me, but someone else must approve -
Simon Schaufelberger commented on patch set 2 09/18/12, 19:54
backports created!