Review main Merged

12713BUGFIX] strftime expects parameter 2 to be long, string given

Jigal van Hemert CR +2 V +2 Easy +2 −0 updated 06/03/13, 20:49

Commit message

Any zero length string value is replaced with the current timestamp.
(Just like the default value for the second parameter of
strtime/gmstrftime.)

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Stefan Neufeind +1
    • Marcus Schwemer +1
  • Verified V +2
    • Jigal van Hemert +2
    • Marcus Schwemer +1

Files 1

Review log 19

  1. Mario Rimann commented on patch set 1 09/18/12, 19:54

    (1 inline comment)

    class.tslib_content.php:2551

    I guess this will work - but I find it rather complicated to read/understand.
  2. Marcus Schwemer commented on patch set 1 09/18/12, 19:54

    Looks good to me, but someone else must approve
  3. Marcus Schwemer voted on patch set 1 V 0 09/18/12, 19:54

  4. Stefan Neufeind commented on patch set 2 09/18/12, 19:54

    Looks good to me, but someone else must approve
    nitpick: Bracket missing before BUGFIX. (Not sure if that might affect automatic parsing of changelog etc.)
  5. Marcus Schwemer commented on patch set 2 09/18/12, 19:54

    Verified; Looks good to me, but someone else must approve
  6. Jigal van Hemert commented on patch set 2 09/18/12, 19:54

    @Simon Do you have time for backports. I can merge them.
  7. Jigal van Hemert commented on patch set 2 09/18/12, 19:54

    Adapted for the namespace situation. Still valid votes from version 1: +1 Verified: 2 +1 Looks good.. : 3 Needs review from core team member.
  8. Jigal van Hemert commented on patch set 2 V 0 09/18/12, 19:54

    by team member; Looks good to me, approved
  9. Jigal van Hemert uploaded patch set 2 09/18/12, 19:54

  10. Jigal van Hemert merged patch set 2 09/18/12, 19:54

  11. Simon Schaufelberger commented on patch set 1 09/18/12, 19:54

    hi mario, this is the same patch applied to the date function after a long discussion.
  12. Simon Schaufelberger commented on patch set 1 09/18/12, 19:54

    Verified; Looks good to me, but someone else must approve
  13. Simon Schaufelberger commented on patch set 1 09/18/12, 19:54

    common guys, please merge that one. it has already been solved for the date function and this is just the same fix for the strftime function.
  14. Simon Schaufelberger commented on patch set 2 09/18/12, 19:54

    finally!!! wow, that took really a looooooong time... PS: the commit message is broken. the missing "[" was not added.
  15. Simon Schaufelberger commented on patch set 2 09/18/12, 19:54

    yes, i have.
  16. Mr. Jenkins commented on patch set 1 09/18/12, 19:54

  17. Mr. Jenkins commented on patch set 2 09/18/12, 19:54

  18. Wouter Wolters commented on patch set 1 09/18/12, 19:54

    Looks good to me, but someone else must approve
  19. Simon Schaufelberger commented on patch set 2 09/18/12, 19:54

    backports created!