Review main Merged

12714[BUGFIX] l10n_mode for "pages" table and group fields.

Erik Frister CR +2 V +2 Normal +120 −11 updated 11/19/13, 22:13

Commit message

This patch respects the l10modes for pages, and mergeIfNotBlank for
type "group" fields.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1

Files 2

Review log 47

Show 22 earlier messages
  1. Georg Ringer commented on patch set 2 05/27/13, 17:19

    (3 inline comments)

    class.t3lib_page.php:322

    strict comparison please

    class.t3lib_page.php:1406

    IMO this is boolean

    class.t3lib_page.php:1414

    $value == 0
  2. Michael Klapper uploaded patch set 3 05/27/13, 17:19

  3. Michael Klapper commented on patch set 3 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve
  4. Johannes Feustel commented on patch set 3 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve
  5. Johannes Feustel uploaded patch set 4 05/27/13, 17:19

  6. Johannes Feustel uploaded patch set 5 05/27/13, 17:19

  7. Tolleiv Nietsch commented on patch set 6 05/27/13, 17:19

    Looks good to me, but someone else must approve
  8. Johannes Feustel uploaded patch set 6 05/27/13, 17:19

  9. Philipp Gampe commented on patch set 2 05/27/13, 17:19

    I just changed the spacing of the commit message.
  10. Philipp Gampe uploaded patch set 2 05/27/13, 17:19

  11. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  12. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  13. Mr. Jenkins commented on patch set 3 05/27/13, 17:19

  14. Mr. Jenkins commented on patch set 4 05/27/13, 17:19

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/8336/ : FAILURE
  15. Mr. Jenkins commented on patch set 5 05/27/13, 17:19

  16. Mr. Jenkins commented on patch set 6 05/27/13, 17:19

  17. Wouter Wolters commented on patch set 3 05/27/13, 17:19

    (4 inline comments)

    class.t3lib_page.php:322

    space after if

    class.t3lib_page.php:332

    Inline comments need to be intended by one tab

    class.t3lib_page.php:1417

    Can we use strict comparrison here?

    class.t3lib_page.php:1423

    Can we use strict comparrison here?
  18. Christian Zenker commented on patch set 6 V -1 CR -1 07/15/13, 14:00

    The patch has a bug so that mergeIfNotBlank on group columns *never* works.

    PageRepository.php:1211

    ambigious name. This variable just stores if the field could be overlaid.

    PageRepository.php:1215

    This line does not do what you would expect! "string" == 0 is *always* TRUE in PHP. see http://php.net/manual/en/types.comparisons.php#types.comparisions-loose This is why group fields are always considered empty with mergeIfNotBlank.

    PageRepository.php:1221

    This condition is very to understand even though it could be very simple.
  19. Markus Klein commented on patch set 6 CR -1 07/15/13, 14:04

    6.2 missing
  20. Christian Zenker uploaded patch set 7 07/15/13, 14:08

  21. Mr. Jenkins commented on patch set 7 07/15/13, 14:09

  22. Markus Klein commented on patch set 7 CR -1 07/15/13, 14:17

    PageRepository.php:335

    speaking names please for new code!

    PageRepository.php:1209

    protected

    PageRepository.php:1210

    isset() check first

    PageRepository.php:1213

    No early return please. Use a $result variable

    PageRepository.php:1219

    combine into 1 if please

    PageRepository.php:1225

    no return here; same as above

    PageRepositoryTest.php:128

    Please adhere naming conventions for tests. @test in docheader and name of function is: <nameOfFunctionUnderTest><WhatIsTested> Look at other tests, for details please.
  1. Christian Zenker uploaded patch set 8 07/15/13, 14:38

  2. Mr. Jenkins commented on patch set 8 07/15/13, 14:39

  3. Markus Klein uploaded patch set 9 07/15/13, 15:02

  4. Mr. Jenkins commented on patch set 9 07/15/13, 15:03

  5. Markus Klein commented on patch set 9 CR +1 07/15/13, 15:03

    Rebased on current master. Can some unittest guru please take a look if the tests are ok? I'm not sure about the reflection stuff. Thx.
  6. Christian Zenker voted on patch set 9 V +1 CR +1 07/16/13, 12:46

  7. Oliver Klee commented on patch set 9 07/16/13, 13:22

    The reflection stuff is quite dirty. Instead, I'd propose to use one of the following approaches: a) make the method public b) test the method/the behavior through some other (public) method c) use $this->getAccessibleMock to make the protected method callable
  8. Markus Klein commented on patch set 9 07/16/13, 20:58

    a) no go: We can't introduce new API in a bugfix b) too difficult I fear c) that's what I thought
  9. Markus Klein uploaded patch set 10 07/16/13, 21:35

  10. Mr. Jenkins commented on patch set 10 07/16/13, 21:36

  11. Christian Zenker voted on patch set 10 CR +1 08/14/13, 16:00

  12. Markus Klein uploaded patch set 11 08/14/13, 17:03

  13. Markus Klein commented on patch set 11 CR +1 08/14/13, 17:04

    Rebased and CGL fixes
  14. Mr. Jenkins commented on patch set 11 08/14/13, 17:04

  15. Markus Klein voted on patch set 11 V +1 11/10/13, 11:42

  16. Markus Klein voted on patch set 11 V 0 11/10/13, 11:45

  17. Markus Klein uploaded patch set 12 11/10/13, 11:49

  18. Markus Klein voted on patch set 12 V +1 CR +1 11/10/13, 11:51

  19. Mr. Jenkins commented on patch set 12 11/10/13, 12:04

  20. Markus Klein rebased onto patch set 12 11/19/13, 00:02

  21. Markus Klein voted on patch set 13 V +1 CR +1 11/19/13, 00:02

  22. Mr. Jenkins commented on patch set 13 11/19/13, 00:28

  23. Wouter Wolters commented on patch set 13 V +1 CR +1 11/19/13, 22:07

    Only verified with the unittest
  24. Markus Klein voted on patch set 13 V +2 CR +2 11/19/13, 22:13

  25. Markus Klein merged patch set 14 11/19/13, 22:13