1274[BUGFIX] Also crop when maxCharacters < first word
Commit message
Review
-
Code review CR +2
- Steffen Gebert +2
-
Verified V +2
- Steffen Gebert +2
Issues 1
Files 2
Review log 13
-
Peter Beernink uploaded patch set 2 05/08/11, 11:24
-
Peter Beernink commented on patch set 2 05/08/11, 11:24
You'r both right. The patch have been modified to meet the failing tests. The HTML dataprovider in the test has been extended to also cover this issue. -
Stefan Neufeind commented on patch set 2 05/08/11, 11:24
Looks good to me, but someone else must approve -
Steffen Gebert uploaded patch set 3 05/08/11, 11:24
-
Steffen Gebert commented on patch set 3 V 0 05/08/11, 11:24
by team member; Looks good to me, approved -
Jigal van Hemert commented on patch set 1 05/08/11, 11:24
These functions are covered by unit tests and they don't show this problem. Maybe it's a good idea to add unit tests that show the problem? That would make sure that future changes don't bring this bug back. -
Philipp Gampe commented on patch set 1 05/08/11, 11:24
Fails Please check those unit tests: cropHtmlWithDataProvider with data set "iso-8859-1 text with entities 14|...|1" cropHTML failed with settings: "14|...|1" and charset "iso-8859-1" Failed asserting that <string:Kasper...> is equal to <string:Kasper Skårhøj...>. -
Philipp Gampe commented on patch set 2 05/08/11, 11:24
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 2 V 0 05/08/11, 11:24
testing by Unit Tests -
Mr. Jenkins commented on patch set 1 05/08/11, 11:24
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/99/ SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/100/ SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/100/ -
Mr. Jenkins commented on patch set 2 05/08/11, 11:24
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/108/ SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/109/ SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/109/ -
Mr. Jenkins commented on patch set 3 05/08/11, 11:24
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/440/ : SUCCESS -
Steffen Gebert merged patch set 3 05/08/11, 11:24