1275[TASK] Remove DEPRECATED static templates
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Markus Klein +1
- Fabien Udriot +1
- Susi Moog +1
-
Verified V +2
- Xavier Perseguers +2
- Fabien Udriot +1
- Susi Moog +1
Files 8
- typo3/sysext/css_styled_content/static/v3.8/setup.txt2+0 −57
- typo3/sysext/css_styled_content/static/v3.9/setup.txt2+2 −59
- typo3/sysext/css_styled_content/static/v4.2/setup.txt2+5 −61
- typo3/sysext/css_styled_content/static/v4.3/setup.txt2+56 −113
- typo3/sysext/css_styled_content/static/v4.4/setup.txt2+0 −57
- typo3/sysext/css_styled_content/static/setup.txt2+0 −57
- typo3/sysext/statictemplates/ext_tables_static+adt.sql+2 −21
- typo3/sysext/t3editor/res/tsref/tsref.xml+33 −33
Review log 12
-
Xavier Perseguers commented on patch set 1 04/07/11, 18:02
(6 inline comments) Took remarks into account -
Markus Klein commented on patch set 2 04/07/11, 18:02
Looks good to me, but someone else must approve Is it really necessary to remove this from all old css_styled_content typoscripts? -
Susi Moog commented on patch set 2 04/07/11, 18:02
Fails; Looks good to me, but someone else must approve I'm not really sure if we should do this... as it kills tt_news. I mean, yes modern plugins register themselves but breaking tt_news is a no-go for me as it's widely used. If we had a workaround there I'd be all for it. -
Susi Moog commented on patch set 2 V 0 04/07/11, 18:02
Xavier: ok, then let's do it now -- could you maybe contact the people responsible for the extensions in question so they are at least warned? Markus: I'd remove it from the old templates, too - these templates provide a compatibility rendering and can be used with new TYPO3 versions to make them render like old versions did -- but there is no point in having the extension inclusion parts in there if they don't work anymore because the templates are missing. -
Xavier Perseguers uploaded patch set 2 04/07/11, 18:02
-
Xavier Perseguers commented on patch set 2 04/07/11, 18:02
tt_news has had and still has enough time to update and be compatible. Ideally the v2.5 (or something like that) should be updated to tackle with this change as I know many agencies that did not update to v3. I want such breaking change to happen now, in order for such extensions to have plenty of time to come up with needed updates. -
Xavier Perseguers commented on patch set 2 V 0 04/07/11, 18:02
by team member; Looks good to me, approved Rupert (tt_news) has been informed by email -
Fabien Udriot commented on patch set 1 04/07/11, 18:02
Verified; Looks good to me, but someone else must approve Big clean up, big patch!setup.txt:1573I think we can remote l:1573. I don't see the reason to keep this "20 {". 1575 should be removed too.setup.txt:1076Remove the line above and the closing bracketsetup.txt:1205Remove the line above and the closing bracket.setup.txt:1222Remove the line above and the closing bracketsetup.txt:1582Remove the line above and the closing bracketsetup.txt:1568Remove the line above and the closing bracket -
Fabien Udriot commented on patch set 2 04/07/11, 18:02
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 04/07/11, 18:02
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/100/ SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/101/ SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/101/ -
Mr. Jenkins commented on patch set 2 04/07/11, 18:02
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/102/ SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/103/ SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/103/ -
Xavier Perseguers merged patch set 2 04/07/11, 18:02