Review TYPO3_4-5 Merged

12840[BUGFIX] undefined variable imgExt

Mario Rimann CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

reducing colors in getImgResource function fails if not using
image-magick

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
    • Marcus Schwemer +1
    • Steffen Ritter +1
  • Verified V +2
    • Wouter Wolters +2
    • Steffen Ritter +1

Files 1

Review log 6

  1. Stefan Neufeind commented on patch set 1 05/12/13, 13:28

    Looks good to me, but someone else must approve
  2. Marcus Schwemer commented on patch set 1 05/12/13, 13:28

    Looks good to me, but someone else must approve
  3. Markus Klein commented on patch set 1 05/12/13, 13:28

    (1 inline comment)

    class.tslib_content.php:5100

    Isn't this here wrong too?
  4. Steffen Ritter commented on patch set 1 05/12/13, 13:28

    Verified; Looks good to me, but someone else must approve
  5. Wouter Wolters commented on patch set 1 V 0 05/12/13, 13:28

    by team member; Looks good to me, approved Same as merged in earlier branches
  6. Wouter Wolters merged patch set 2 05/12/13, 13:28