Review main Merged

12847[BUGFIX] QT movies prefixed abusively in Media CE

Francois Suter CR +2 V +2 Easy +6 −1 updated 06/03/13, 20:49

Commit message

If some prefixes are defined (either base URL or absRefPrefix),
the Media CE will apply such prefix to any Quicktime movie
even if said movie is referenced by an absolute URL.

Review

  • Code review CR +2
    • Francois Suter +2
  • Verified V +2
    • Francois Suter +2

Files 1

Review log 10

  1. Ernesto Baschny commented on patch set 1 07/21/12, 21:03

    Verified; Looks good to me, but someone else must approve
  2. Francois Suter uploaded patch set 2 07/21/12, 21:03

  3. Francois Suter commented on patch set 2 V 0 07/21/12, 21:03

    by team member; Looks good to me, approved
  4. Francois Suter commented on patch set 2 07/21/12, 21:03

    Just rebased the patch to be on the safe side before merging.
  5. Francois Suter merged patch set 2 07/21/12, 21:03

  6. Philipp Gampe commented on patch set 1 07/21/12, 21:03

    Looks good to me, but someone else must approve
  7. Mr. Jenkins commented on patch set 1 07/21/12, 21:03

  8. Mr. Jenkins commented on patch set 2 07/21/12, 21:03

  9. Wouter Wolters commented on patch set 1 07/21/12, 21:03

    Looks good to me, but someone else must approve
  10. Ernesto Baschny commented on patch set 2 07/21/12, 21:03

    Francois, just a informative note: if you cherry-pick the change on top of current branchs head locally and it doesn't choke, it will also not choke when merging here through Gerrit, as it does a simple cherry-pick too.