Review main Merged

13020[BUGFIX] Invalid fallback for non-localized labels

Xavier Perseguers CR +2 V +2 Easy +24 −8 updated 06/03/13, 20:49

Commit message

Whenever a record is not translated, Pootle exports the localization file
with only the "source" element and no "target" element.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Oliver Hader +2
    • Helmut Hummel +1
  • Verified V +2
    • Xavier Perseguers +2

Files 1

Review log 10

  1. Xavier Perseguers uploaded patch set 2 07/24/12, 15:11

  2. Oliver Hader commented on patch set 3 07/24/12, 15:11

    Looks good to me, approved
  3. Xavier Perseguers uploaded patch set 3 07/24/12, 15:11

  4. Helmut Hummel commented on patch set 3 07/24/12, 15:11

    Looks good to me, but someone else must approve
  5. Mr. Jenkins commented on patch set 1 07/24/12, 15:11

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/4994/ : FAILURE
  6. Mr. Jenkins commented on patch set 2 07/24/12, 15:11

  7. Mr. Jenkins commented on patch set 3 07/24/12, 15:11

  8. Xavier Perseguers commented on patch set 3 V 0 07/24/12, 15:11

    by team member; Looks good to me, approved
  9. Xavier Perseguers merged patch set 3 07/24/12, 15:11

  10. Xavier Perseguers commented on patch set 3 08/15/12, 17:33

    Reverted This patchset was reverted in change: Ie6ff57312aeb359fe4cf359c917274c6b26cbe37