13451[BUGFIX] Possible fatal if sys_notes table is broken
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Markus Günther +1
-
Verified V +2
- Christian Kuhn +2
- Markus Günther +1
Files 1
Review log 23
-
Anja Leichsenring uploaded patch set 2 08/05/12, 20:57
-
Oliver Klee commented on patch set 3 2 comments 08/05/12, 20:57
I would prefer that you didn't submit this -
Max Roesch commented on patch set 3 08/05/12, 20:57
Verified; Looks good to me, but someone else must approve -
Anja Leichsenring uploaded patch set 3 08/05/12, 20:57
-
Oliver Klee commented on patch set 4 1 comment 08/05/12, 20:57
Looks good to me, but someone else must approve -
Markus Günther uploaded patch set 5 08/05/12, 20:57
-
Anja Leichsenring uploaded patch set 4 08/05/12, 20:57
-
Christian Kuhn commented on patch set 6 08/05/12, 20:57
I think the description is misleading: exec_SELECTgetRows() always returns an array (also an empty one). It only returns NULL and thus triggers a fatal, if the table schema is broken and the query fails. So, it is not 'fatal if no records are found', but 'fatal if sql query was broken' -
Christian Kuhn uploaded patch set 7 08/05/12, 20:57
-
Markus Günther commented on patch set 6 08/05/12, 20:57
Verified; Looks good to me, but someone else must approve -
Markus Günther commented on patch set 7 08/05/12, 20:57
Verified; Looks good to me, but someone else must approve -
Anja Leichsenring uploaded patch set 6 08/05/12, 20:57
-
Mr. Jenkins commented on patch set 1 08/05/12, 20:57
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/5122/ : FAILURE -
Mr. Jenkins commented on patch set 2 08/05/12, 20:57
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5123/ : SUCCESS -
Mr. Jenkins commented on patch set 3 08/05/12, 20:57
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5125/ : SUCCESS -
Mr. Jenkins commented on patch set 4 08/05/12, 20:57
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5139/ : SUCCESS -
Mr. Jenkins commented on patch set 5 08/05/12, 20:57
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/5140/ : FAILURE -
Mr. Jenkins commented on patch set 6 08/05/12, 20:57
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5141/ : SUCCESS -
Mr. Jenkins commented on patch set 7 08/05/12, 20:57
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5142/ : SUCCESS -
Alexander Schnitzler commented on patch set 2 08/05/12, 20:57
Looks good to me, but someone else must approveSysNote.php:23Please add another one here ;) -
Alexander Schnitzler commented on patch set 3 08/05/12, 20:57
Verified; Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 7 V 0 08/05/12, 20:57
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 7 08/05/12, 20:57