Review main Merged

13451[BUGFIX] Possible fatal if sys_notes table is broken

Anja Leichsenring CR +2 V +2 Easy +6 −0 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Günther +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Günther +1

Files 1

Review log 23

  1. Anja Leichsenring uploaded patch set 2 08/05/12, 20:57

  2. Oliver Klee commented on patch set 3 2 comments 08/05/12, 20:57

    I would prefer that you didn't submit this
  3. Max Roesch commented on patch set 3 08/05/12, 20:57

    Verified; Looks good to me, but someone else must approve
  4. Anja Leichsenring uploaded patch set 3 08/05/12, 20:57

  5. Oliver Klee commented on patch set 4 1 comment 08/05/12, 20:57

    Looks good to me, but someone else must approve
  6. Markus Günther uploaded patch set 5 08/05/12, 20:57

  7. Anja Leichsenring uploaded patch set 4 08/05/12, 20:57

  8. Christian Kuhn commented on patch set 6 08/05/12, 20:57

    I think the description is misleading: exec_SELECTgetRows() always returns an array (also an empty one). It only returns NULL and thus triggers a fatal, if the table schema is broken and the query fails. So, it is not 'fatal if no records are found', but 'fatal if sql query was broken'
  9. Christian Kuhn uploaded patch set 7 08/05/12, 20:57

  10. Markus Günther commented on patch set 6 08/05/12, 20:57

    Verified; Looks good to me, but someone else must approve
  11. Markus Günther commented on patch set 7 08/05/12, 20:57

    Verified; Looks good to me, but someone else must approve
  12. Anja Leichsenring uploaded patch set 6 08/05/12, 20:57

  13. Mr. Jenkins commented on patch set 1 08/05/12, 20:57

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/5122/ : FAILURE
  14. Mr. Jenkins commented on patch set 2 08/05/12, 20:57

  15. Mr. Jenkins commented on patch set 3 08/05/12, 20:57

  16. Mr. Jenkins commented on patch set 4 08/05/12, 20:57

  17. Mr. Jenkins commented on patch set 5 08/05/12, 20:57

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/5140/ : FAILURE
  18. Mr. Jenkins commented on patch set 6 08/05/12, 20:57

  19. Mr. Jenkins commented on patch set 7 08/05/12, 20:57

  20. Alexander Schnitzler commented on patch set 2 08/05/12, 20:57

    Looks good to me, but someone else must approve

    SysNote.php:23

    Please add another one here ;)
  21. Alexander Schnitzler commented on patch set 3 08/05/12, 20:57

    Verified; Looks good to me, but someone else must approve
  22. Christian Kuhn commented on patch set 7 V 0 08/05/12, 20:57

    by team member; Looks good to me, approved
  23. Christian Kuhn merged patch set 7 08/05/12, 20:57