Review main Merged

13800Revert "[BUGFIX] Invalid fallback for non-localized labels"

Xavier Perseguers CR +2 V +2 Easy +8 −24 updated 06/03/13, 20:49

Commit message

This reverts commit 55ff38c77f143829ed078e0f7dda12b51d76254b

Real bug is in Extbase: #36905 and #39569

Review

  • Code review CR +2
    • Xavier Perseguers +2
  • Verified V +2
    • Xavier Perseguers +2

Files 1

Review log 9

  1. Xavier Perseguers commented on patch set 1 08/31/12, 09:16

    Which unit tests? This change was not covered by other unit tests when it was committed. So the "revert" is OK. Additional unit tests may of course be added but this is another situation in regard to Gerrit.
  2. Xavier Perseguers uploaded patch set 2 08/31/12, 09:16

  3. Tymoteusz Motylewski commented on patch set 1 08/31/12, 09:16

    No score I was thinking about the missing unit tests, which didn't go red after changing code :) But you're also right that this can be done in separate patch, not to postpone this one.
  4. Tymoteusz Motylewski commented on patch set 1 08/31/12, 09:16

    I would prefer that you didn't submit this It would be nice to update unit tests to cover this change.
  5. Dominique Feyer commented on patch set 1 08/31/12, 09:16

    Verified; Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 1 08/31/12, 09:16

  7. Mr. Jenkins commented on patch set 2 08/31/12, 09:16

  8. Xavier Perseguers commented on patch set 2 V 0 08/31/12, 09:16

    by team member; Looks good to me, approved Adapted for namespaces
  9. Xavier Perseguers merged patch set 2 08/31/12, 09:16