13817[BUGFIX] Label in list view is not escaped
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Philipp Gampe +1
-
Verified V +2
- Stefan Neufeind +2
- Philipp Gampe +1
Files 2
Review log 31
Show 6 earlier messages
-
Stefan Neufeind uploaded patch set 2 05/05/13, 11:30
and 6.1 -
Stefan Neufeind commented on patch set 2 05/05/13, 11:30
hand-rebased. had 2x +1-by-reading -
Stefan Neufeind commented on patch set 2 05/05/13, 11:30
(1 inline comment) -
Stefan Neufeind commented on patch set 3 05/05/13, 11:30
Looks good to me, but someone else must approve -
Benni Mack commented on patch set 3 05/05/13, 11:30
I would prefer that you didn't submit this Not as trivial as it looks. When we HSC the text, then also the wrap <i>[|]</i> gets escaped. see BackendUtility::getItemLabel for that. This function is completely broken for the HSC-functionality. Clean solution is to remove the third parameter (as it is only used in this one occurence) and then do the HSC in a clean way, and the wrap later on. I will submit a new patch. -
Benni Mack uploaded patch set 4 05/05/13, 11:30
-
Stefan Neufeind commented on patch set 5 05/05/13, 11:30
Looks good to me, but someone else must approve -
Benni Mack uploaded patch set 5 05/05/13, 11:30
-
Xavier Perseguers uploaded patch set 3 05/05/13, 11:30
-
Christian Weiske commented on patch set 2 05/05/13, 11:30
Verified; Looks good to me, but someone else must approve TYPO3 now displays colum titles like "<title>" fine in the record list table. -
Christian Weiske commented on patch set 3 05/05/13, 11:30
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 5 05/05/13, 11:30
Fails does not solve the original issue double encoding in translation view still happens inside the translation hints: * create a content element mit two quotes (RTE) * create a translation of this content element * open the new translation and watch the translation hint below the RTE field -
Philipp Gampe commented on patch set 5 05/05/13, 11:30
No score wrong patch :( -
Philipp Gampe commented on patch set 5 05/05/13, 11:30
Verified; Looks good to me, but someone else must approve -
Mattias Nilsson commented on patch set 1 05/05/13, 11:30
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 05/05/13, 11:30
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5289/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/05/13, 11:30
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6846/ : SUCCESS -
Mr. Jenkins commented on patch set 3 05/05/13, 11:30
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7617/ : SUCCESS -
Mr. Jenkins commented on patch set 4 05/05/13, 11:30
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8224/ : SUCCESS -
Mr. Jenkins commented on patch set 5 05/05/13, 11:30
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8236/ : SUCCESS -
Wouter Wolters commented on patch set 1 05/05/13, 11:30
Looks good to me, but someone else must approve -
Wouter Wolters commented on patch set 3 05/05/13, 11:30
Looks good to me, but someone else must approve -
Nicole Hummel commented on patch set 4 05/05/13, 11:30
(1 inline comment)BackendUtility.php:1801Please don't change the return value as this would be an api change. -
Nicole Hummel commented on patch set 4 05/05/13, 11:30
I would prefer that you didn't submit this Seems there are some problems with your master? SystemEnvironmentCheck (and maybe other cleanup) are not related to the origin issue -
Nicole Hummel commented on patch set 5 05/05/13, 11:30
Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 6 05/05/13, 11:30
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 6 05/05/13, 11:30
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 6 05/05/13, 11:30
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8680/ : SUCCESS -
Nicole Hummel uploaded patch set 6 05/05/13, 11:30
-
Stefan Neufeind commented on patch set 6 V 0 05/05/13, 11:30
by team member; Looks good to me, approved -
Stefan Neufeind merged patch set 7 05/05/13, 11:30