Review main Merged

13817[BUGFIX] Label in list view is not escaped

Georg Ringer CR +2 V +2 Easy +19 −4 updated 06/03/13, 20:49

Commit message

The label of a field in the list view is not escaped,
as the itemLabel function is broken, through the
third parameter which cannot be HSCed afterwards
if it contains HTML.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Philipp Gampe +1
  • Verified V +2
    • Stefan Neufeind +2
    • Philipp Gampe +1

Files 2

Review log 31

Show 6 earlier messages
  1. Stefan Neufeind uploaded patch set 2 05/05/13, 11:30

    and 6.1
  2. Stefan Neufeind commented on patch set 2 05/05/13, 11:30

    hand-rebased. had 2x +1-by-reading
  3. Stefan Neufeind commented on patch set 2 05/05/13, 11:30

    (1 inline comment)
  4. Stefan Neufeind commented on patch set 3 05/05/13, 11:30

    Looks good to me, but someone else must approve
  5. Benni Mack commented on patch set 3 05/05/13, 11:30

    I would prefer that you didn't submit this Not as trivial as it looks. When we HSC the text, then also the wrap <i>[|]</i> gets escaped. see BackendUtility::getItemLabel for that. This function is completely broken for the HSC-functionality. Clean solution is to remove the third parameter (as it is only used in this one occurence) and then do the HSC in a clean way, and the wrap later on. I will submit a new patch.
  6. Benni Mack uploaded patch set 4 05/05/13, 11:30

  1. Stefan Neufeind commented on patch set 5 05/05/13, 11:30

    Looks good to me, but someone else must approve
  2. Benni Mack uploaded patch set 5 05/05/13, 11:30

  3. Xavier Perseguers uploaded patch set 3 05/05/13, 11:30

  4. Christian Weiske commented on patch set 2 05/05/13, 11:30

    Verified; Looks good to me, but someone else must approve TYPO3 now displays colum titles like "<title>" fine in the record list table.
  5. Christian Weiske commented on patch set 3 05/05/13, 11:30

    Verified; Looks good to me, but someone else must approve
  6. Philipp Gampe commented on patch set 5 05/05/13, 11:30

    Fails does not solve the original issue double encoding in translation view still happens inside the translation hints: * create a content element mit two quotes (RTE) * create a translation of this content element * open the new translation and watch the translation hint below the RTE field
  7. Philipp Gampe commented on patch set 5 05/05/13, 11:30

    No score wrong patch :(
  8. Philipp Gampe commented on patch set 5 05/05/13, 11:30

    Verified; Looks good to me, but someone else must approve
  9. Mattias Nilsson commented on patch set 1 05/05/13, 11:30

    Looks good to me, but someone else must approve
  10. Mr. Jenkins commented on patch set 1 05/05/13, 11:30

  11. Mr. Jenkins commented on patch set 2 05/05/13, 11:30

  12. Mr. Jenkins commented on patch set 3 05/05/13, 11:30

  13. Mr. Jenkins commented on patch set 4 05/05/13, 11:30

  14. Mr. Jenkins commented on patch set 5 05/05/13, 11:30

  15. Wouter Wolters commented on patch set 1 05/05/13, 11:30

    Looks good to me, but someone else must approve
  16. Wouter Wolters commented on patch set 3 05/05/13, 11:30

    Looks good to me, but someone else must approve
  17. Nicole Hummel commented on patch set 4 05/05/13, 11:30

    (1 inline comment)

    BackendUtility.php:1801

    Please don't change the return value as this would be an api change.
  18. Nicole Hummel commented on patch set 4 05/05/13, 11:30

    I would prefer that you didn't submit this Seems there are some problems with your master? SystemEnvironmentCheck (and maybe other cleanup) are not related to the origin issue
  19. Nicole Hummel commented on patch set 5 05/05/13, 11:30

    Looks good to me, but someone else must approve
  20. Stefan Neufeind commented on patch set 6 05/05/13, 11:30

    Verified; Looks good to me, but someone else must approve
  21. Philipp Gampe commented on patch set 6 05/05/13, 11:30

    Verified; Looks good to me, but someone else must approve
  22. Mr. Jenkins commented on patch set 6 05/05/13, 11:30

  23. Nicole Hummel uploaded patch set 6 05/05/13, 11:30

  24. Stefan Neufeind commented on patch set 6 V 0 05/05/13, 11:30

    by team member; Looks good to me, approved
  25. Stefan Neufeind merged patch set 7 05/05/13, 11:30