Review TYPO3_4-7 Merged

13895[BUGFIX] backColor transparent causes black background or flickering

Wouter Wolters CR +2 V +2 Easy +2 −7 updated 06/03/13, 20:49

Commit message

When a GIFBUILDER object has set its backColor option to transparent,
the background may be black when adding a IMAGE object to it, and inner
areas of TEXT elements may be completly transparent, ignoring the
transparency by underlying elements.

This patch, removes the "imagealphablending" function calls, which
caused the latter issue and adds an additional check to the
tslib_stdGraphic::imagecopyresized method to prevent useage of the
imagecopyresized_fix workaround when working with transparency, as
it is responsible for the black background.

Backwards compatibility is not affected, since upgraded systems will
not have a backColor=transparent setting, thus have the property
saveAlphaLayer set to FALSE in any case.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Files 2