1390[BUGFIX] Module -> List + "List only this table" search not working past page 1
Commit message
Review
-
Code review CR +2
- Ernesto Baschny +2
- Björn Pedersen +1
-
Verified V +2
- Ernesto Baschny +2
- Björn Pedersen +1
Issues 1
Files 1
Review log 8
-
Ernesto Baschny commented on patch set 1 04/01/11, 09:39
Fails; I would prefer that you didn't submit this What happens if you have a search result that is multi-pages? You won't get pass page 1, because the pointer is always reset to "0". Instead, the pointer should be made "0" only when the "Search" button is hit, and not on all hits. I will push a new patch fixing that in a minute. -
Ernesto Baschny uploaded patch set 2 04/01/11, 09:39
-
Ernesto Baschny commented on patch set 2 04/01/11, 09:39
Verified; Looks good to me, but someone else must approve Patchset #2: Skip the currently set "pointer" parameter when someone hits the "Search" FORM below the list -
Björn Pedersen commented on patch set 2 04/01/11, 09:39
Verified; Looks good to me, but someone else must approve Yes, that is a better solution to the problem. -
Mr. Jenkins commented on patch set 1 04/01/11, 09:39
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/184/ -
Mr. Jenkins commented on patch set 2 04/01/11, 09:39
Build Successful SUCCESS: http://ci.typo3.org/job/typo3-v4-core-gerrit/186/ -
Ernesto Baschny commented on patch set 2 V 0 04/01/11, 09:39
by team member; Looks good to me, approved -
Ernesto Baschny merged patch set 2 04/01/11, 09:39