14213[BUGFIX] Ensure write access to LocalConfiguration.php
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Christian Kuhn +1
-
Verified V +2
- Georg Ringer +2
- Christian Kuhn +1
Files 2
Review log 32
Show 7 earlier messages
-
Anja Leichsenring commented on patch set 1 09/22/12, 12:00
Fails a test fails, and I will write another one. -
Mr. Jenkins commented on patch set 1 09/22/12, 12:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5589/ : SUCCESS -
Mr. Jenkins commented on patch set 2 09/22/12, 12:00
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/5591/ : FAILURE -
Nicole Hummel uploaded patch set 2 09/22/12, 12:00
-
Oliver Klee commented on patch set 3 09/22/12, 12:00
(5 inline comments)Nitpick: check -> CheckConfigurationManager.php:173This needs to be a specific Exception subclass (e.g. a RuntimeException). Otherwise, this exception cannot be unit-tested.ConfigurationManagerTest.php:194Nitpick: Generally, this kind of comment block should be separate and not be part of the method documentation comment: /* * Tests concerning Foo */ /** * @test */ public function ...ConfigurationManagerTest.php:203We don't need the else here because markTestSkipped exits the method. So the fclose can located be after the if.ConfigurationManagerTest.php:207I'd prefer this to be a guard clause (or to throw an exception so we know there is a problem.) -
Mr. Jenkins commented on patch set 3 09/22/12, 12:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5592/ : SUCCESS -
Nicole Hummel uploaded patch set 3 09/22/12, 12:00
-
Mr. Jenkins commented on patch set 4 09/22/12, 12:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5613/ : SUCCESS -
Nicole Hummel uploaded patch set 4 09/22/12, 12:00
-
Oliver Klee commented on patch set 5 09/22/12, 12:00
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 5 V 0 09/22/12, 12:00
Works, but exception is not caught in e.g. the extension manager. Unit tests work.ConfigurationManager.php:168not RuntimeException? -
Philipp Gampe commented on patch set 5 1 comment 09/22/12, 12:00
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 5 09/22/12, 12:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5614/ : SUCCESS -
Wouter Wolters commented on patch set 5 09/22/12, 12:00
Looks good to me, but someone else must approve -
Nicole Hummel uploaded patch set 5 09/22/12, 12:00
-
Georg Ringer commented on patch set 6 09/22/12, 12:00
(2 inline comments) -
Mr. Jenkins commented on patch set 6 09/22/12, 12:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5945/ : SUCCESS -
Nicole Hummel uploaded patch set 6 09/22/12, 12:00
-
Nicole Hummel commented on patch set 6 09/22/12, 12:00
Rebased to current master and changed the PhpDoc @throws -
Georg Ringer voted on patch set 7 V 0 2 comments 09/22/12, 12:00
-
Markus Klein commented on patch set 8 1 comment 09/22/12, 12:00
I would prefer that you didn't submit this -
Georg Ringer uploaded patch set 8 09/22/12, 12:00
-
Christian Kuhn uploaded patch set 10 09/22/12, 12:00
-
Christian Kuhn commented on patch set 10 09/22/12, 12:00
Verified; Looks good to me, but someone else must approve -
Georg Ringer uploaded patch set 9 09/22/12, 12:00
-
Mr. Jenkins commented on patch set 7 09/22/12, 12:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5947/ : SUCCESS -
Mr. Jenkins commented on patch set 9 09/22/12, 12:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5960/ : SUCCESS -
Mr. Jenkins commented on patch set 10 09/22/12, 12:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5975/ : SUCCESS -
Nicole Hummel uploaded patch set 7 09/22/12, 12:00
-
Nicole Hummel commented on patch set 9 09/22/12, 12:00
Verified; Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 10 V 0 09/22/12, 12:00
by team member; Looks good to me, approved -
Georg Ringer merged patch set 10 09/22/12, 12:00