Review main Merged

14213[BUGFIX] Ensure write access to LocalConfiguration.php

Anja Leichsenring CR +2 V +2 Normal +80 −37 updated 06/03/13, 20:49

Commit message

Check the proper write access for LocalConfiguration.php file
before try to store data there. At the moment the attempt to
write silently failes.

Introduce throwing a RuntimeException in case of failing write access.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2
    • Georg Ringer +2
    • Christian Kuhn +1

Files 2

Review log 32

Show 7 earlier messages
  1. Anja Leichsenring commented on patch set 1 09/22/12, 12:00

    Fails a test fails, and I will write another one.
  2. Mr. Jenkins commented on patch set 1 09/22/12, 12:00

  3. Mr. Jenkins commented on patch set 2 09/22/12, 12:00

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/5591/ : FAILURE
  4. Nicole Hummel uploaded patch set 2 09/22/12, 12:00

  5. Oliver Klee commented on patch set 3 09/22/12, 12:00

    (5 inline comments)
    Nitpick: check -> Check

    ConfigurationManager.php:173

    This needs to be a specific Exception subclass (e.g. a RuntimeException). Otherwise, this exception cannot be unit-tested.

    ConfigurationManagerTest.php:194

    Nitpick: Generally, this kind of comment block should be separate and not be part of the method documentation comment: /* * Tests concerning Foo */ /** * @test */ public function ...

    ConfigurationManagerTest.php:203

    We don't need the else here because markTestSkipped exits the method. So the fclose can located be after the if.

    ConfigurationManagerTest.php:207

    I'd prefer this to be a guard clause (or to throw an exception so we know there is a problem.)
  6. Mr. Jenkins commented on patch set 3 09/22/12, 12:00

  7. Nicole Hummel uploaded patch set 3 09/22/12, 12:00

  1. Mr. Jenkins commented on patch set 4 09/22/12, 12:00

  2. Nicole Hummel uploaded patch set 4 09/22/12, 12:00

  3. Oliver Klee commented on patch set 5 09/22/12, 12:00

    Looks good to me, but someone else must approve
  4. Philipp Gampe commented on patch set 5 V 0 09/22/12, 12:00

    Works, but exception is not caught in e.g. the extension manager. Unit tests work.

    ConfigurationManager.php:168

    not RuntimeException?
  5. Philipp Gampe commented on patch set 5 1 comment 09/22/12, 12:00

    Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 5 09/22/12, 12:00

  7. Wouter Wolters commented on patch set 5 09/22/12, 12:00

    Looks good to me, but someone else must approve
  8. Nicole Hummel uploaded patch set 5 09/22/12, 12:00

  9. Georg Ringer commented on patch set 6 09/22/12, 12:00

    (2 inline comments)
  10. Mr. Jenkins commented on patch set 6 09/22/12, 12:00

  11. Nicole Hummel uploaded patch set 6 09/22/12, 12:00

  12. Nicole Hummel commented on patch set 6 09/22/12, 12:00

    Rebased to current master and changed the PhpDoc @throws
  13. Georg Ringer voted on patch set 7 V 0 2 comments 09/22/12, 12:00

  14. Markus Klein commented on patch set 8 1 comment 09/22/12, 12:00

    I would prefer that you didn't submit this
  15. Georg Ringer uploaded patch set 8 09/22/12, 12:00

  16. Christian Kuhn uploaded patch set 10 09/22/12, 12:00

  17. Christian Kuhn commented on patch set 10 09/22/12, 12:00

    Verified; Looks good to me, but someone else must approve
  18. Georg Ringer uploaded patch set 9 09/22/12, 12:00

  19. Mr. Jenkins commented on patch set 7 09/22/12, 12:00

  20. Mr. Jenkins commented on patch set 9 09/22/12, 12:00

  21. Mr. Jenkins commented on patch set 10 09/22/12, 12:00

  22. Nicole Hummel uploaded patch set 7 09/22/12, 12:00

  23. Nicole Hummel commented on patch set 9 09/22/12, 12:00

    Verified; Looks good to me, but someone else must approve
  24. Georg Ringer commented on patch set 10 V 0 09/22/12, 12:00

    by team member; Looks good to me, approved
  25. Georg Ringer merged patch set 10 09/22/12, 12:00