Review main Abandoned

14276[BUGFIX] Clicking on "configure" can lead to an exception

Susi Moog CR 0 V 0 Easy +13 −8 updated 06/03/13, 20:49

Commit message

On clicking configure an Exception may be thrown if the extension
had no previous configuration as the extension manager tries to
merge the existing configuration with the new configuration even
if there is no existing configuration.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 5

  1. Christian Kuhn commented on patch set 1 02/03/13, 20:44

    (1 inline comment)

    ConfigurationItemRepository.php:195

    try on configurationHandler getKey should be used here.
  2. Christian Kuhn commented on patch set 1 02/03/13, 20:44

    I would prefer that you didn't submit this
  3. Christian Kuhn commented on patch set 1 02/03/13, 20:44

    Do not submit Will be handled with https://review.typo3.org/#/c/14548/ ... please abandon this one here.
  4. Mr. Jenkins commented on patch set 1 02/03/13, 20:44

  5. Christian Kuhn commented on patch set 1 02/03/13, 20:44

    Abandoned