14278[BUGFIX] Saving extension settings for option values may fail
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 1
Review log 6
-
Mario Rimann commented on patch set 1 05/27/13, 17:19
I would prefer that you didn't submit thisConfigurationItemRepository.php:119Please add some comment here - I think it's not obvious what's getting done hereConfigurationItemRepository.php:120For what are we checking here? Shouldn't this be something like is_array($labelMatches) && count($labelMatches)?ConfigurationItemRepository.php:128I find these three lines very hard to read, especially because of the used short notation of the if combined with a strange indentation of the different method calls that are called inside each other -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5651/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6467/ : SUCCESS -
Philipp Schiffmann uploaded patch set 2 05/27/13, 17:19
-
Wouter Wolters commented on patch set 2 05/28/13, 18:30
Fails; I would prefer that you didn't submit this I could not reproduce this on newest TYPO3 6.0 release. -
Susi Moog abandoned the change 07/01/13, 13:56