Review main Abandoned

14278[BUGFIX] Saving extension settings for option values may fail

Susi Moog CR 0 V 0 Easy +13 −1 updated 07/01/13, 13:56

Commit message

Saving option values may save wrong settings as the extension manager
does not recognize the format "label here=value".

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 6

  1. Mario Rimann commented on patch set 1 05/27/13, 17:19

    I would prefer that you didn't submit this

    ConfigurationItemRepository.php:119

    Please add some comment here - I think it's not obvious what's getting done here

    ConfigurationItemRepository.php:120

    For what are we checking here? Shouldn't this be something like is_array($labelMatches) && count($labelMatches)?

    ConfigurationItemRepository.php:128

    I find these three lines very hard to read, especially because of the used short notation of the if combined with a strange indentation of the different method calls that are called inside each other
  2. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  3. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  4. Philipp Schiffmann uploaded patch set 2 05/27/13, 17:19

  5. Wouter Wolters commented on patch set 2 05/28/13, 18:30

    Fails; I would prefer that you didn't submit this I could not reproduce this on newest TYPO3 6.0 release.
  6. Susi Moog abandoned the change 07/01/13, 13:56