14282[BUGFIX] Fatal error in GeneralUtility::logDeprecatedFunction()
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Markus Klein +1
-
Verified V +2
- Christian Kuhn +2
- Markus Klein +1
Issues 1
Files 1
Review log 13
-
Andreas Wolf commented on patch set 2 09/22/12, 15:22
You could add a call to GenericUtility::logDeprecatedFunction() somewhere in EXT:core/Classes/Core/Bootstrap.php. See typo3/init.php for all methods that are called before the autoloader registration. A good place might be baseSetup() after the call to SystemEnvironmentBuilder::run() (because GeneralUtility is included during that run). -
Andreas Wolf uploaded patch set 2 09/22/12, 15:22
-
Markus Klein commented on patch set 2 09/22/12, 15:22
Looks good to me, but someone else must approve How to test that? -
Christian Kuhn commented on patch set 1 09/22/12, 15:22
I would prefer that you didn't submit this Could we move this require to the method that needs it? I think there is already some other require in there, for similar reasons. -
Christian Kuhn commented on patch set 1 09/22/12, 15:22
background: otherwise this require is *always* done even if no deprecationLog is written, because GeneralUtility is itself required during bootstrap. -
Christian Kuhn commented on patch set 2 09/22/12, 15:22
BTW: To finally solve this sort of issues, it would be much better if those deprecationLogs are gathered on a stack per run, and then written to the destination during shutdown(). The bootstrap now has such a shutdown functionality. I guess, this would also be cool for the error handling stuff, because this area of the core is extremly nasty to handle currently. -
Markus Klein commented on patch set 3 09/22/12, 15:22
Verified; Looks good to me, but someone else must approve -
Christian Kuhn uploaded patch set 3 09/22/12, 15:22
-
Christian Kuhn commented on patch set 3 V 0 09/22/12, 15:22
by team member; Looks good to me, approved -
Mr. Jenkins commented on patch set 1 09/22/12, 15:22
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5656/ : SUCCESS -
Mr. Jenkins commented on patch set 2 09/22/12, 15:22
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5663/ : SUCCESS -
Mr. Jenkins commented on patch set 3 09/22/12, 15:22
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5983/ : SUCCESS -
Christian Kuhn merged patch set 3 09/22/12, 15:22