Review main Merged

14282[BUGFIX] Fatal error in GeneralUtility::logDeprecatedFunction()

Andreas Wolf CR +2 V +2 Easy +7 −0 updated 06/03/13, 20:49

Commit message

logDeprecatedFunction() uses DebugUtility::debugTrail(), which might not
be available when the deprecated function is called before or while
instantiating the autoloader.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Klein +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1

Issues 1

Files 1

Review log 13

  1. Andreas Wolf commented on patch set 2 09/22/12, 15:22

    You could add a call to GenericUtility::logDeprecatedFunction() somewhere in EXT:core/Classes/Core/Bootstrap.php. See typo3/init.php for all methods that are called before the autoloader registration. A good place might be baseSetup() after the call to SystemEnvironmentBuilder::run() (because GeneralUtility is included during that run).
  2. Andreas Wolf uploaded patch set 2 09/22/12, 15:22

  3. Markus Klein commented on patch set 2 09/22/12, 15:22

    Looks good to me, but someone else must approve How to test that?
  4. Christian Kuhn commented on patch set 1 09/22/12, 15:22

    I would prefer that you didn't submit this Could we move this require to the method that needs it? I think there is already some other require in there, for similar reasons.
  5. Christian Kuhn commented on patch set 1 09/22/12, 15:22

    background: otherwise this require is *always* done even if no deprecationLog is written, because GeneralUtility is itself required during bootstrap.
  6. Christian Kuhn commented on patch set 2 09/22/12, 15:22

    BTW: To finally solve this sort of issues, it would be much better if those deprecationLogs are gathered on a stack per run, and then written to the destination during shutdown(). The bootstrap now has such a shutdown functionality. I guess, this would also be cool for the error handling stuff, because this area of the core is extremly nasty to handle currently.
  7. Markus Klein commented on patch set 3 09/22/12, 15:22

    Verified; Looks good to me, but someone else must approve
  8. Christian Kuhn uploaded patch set 3 09/22/12, 15:22

  9. Christian Kuhn commented on patch set 3 V 0 09/22/12, 15:22

    by team member; Looks good to me, approved
  10. Mr. Jenkins commented on patch set 1 09/22/12, 15:22

  11. Mr. Jenkins commented on patch set 2 09/22/12, 15:22

  12. Mr. Jenkins commented on patch set 3 09/22/12, 15:22

  13. Christian Kuhn merged patch set 3 09/22/12, 15:22