Review main Merged

14295[BUGFIX] LogLevelTest dataProvider not used

Christian Kuhn CR +2 V +2 Normal +43 −36 updated 06/03/13, 20:49

Commit message

isValidLevelThrowsExceptionOnInvalidLevelIfAskedToDoSo() test throwed a
warning that required input parameter $inputValue was not used. This was
because of a typo @dataprovider -> @dataProvider, so the data provider
was not used at all. Fixing this, one of the tests with the
object \stdClass failed.
This turned out to be an error in the thrown exception in validateLevel
 because the exception is not thrown, if the exception message is
compiled from a string and an object. Therefore, the parameter $level
is now left out in method validateLevel().
As additional cleanup, the MathUtilityTest is moved from t3lib to core
extension, and the rootline test and fixture names are adapted.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Files 6