Review main Merged

14299[BUGFIX] Selection of Multiple Collections in CE Uploads

Steffen Ritter CR +2 V +2 Easy +4 −1 updated 06/03/13, 20:49

Commit message

Due to a missing TCA-definition it is not possible to
select more than one collection in a content element
of type "uploads".

With adding the missing TCA this works again.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Mario Rimann +1
  • Verified V +2
    • Jigal van Hemert +2
    • Mario Rimann +1

Files 1

Review log 10

  1. Mario Rimann commented on patch set 1 09/06/12, 13:27

    Looks good to me, but someone else must approve It's pushed to a wrong topic (404545 instead of 40545), but the rest seems ok.
  2. Mario Rimann uploaded patch set 2 09/06/12, 13:27

  3. Mario Rimann commented on patch set 2 09/06/12, 13:27

    Looks good to me, but someone else must approve Just uploaded a new change set, that sets the lower boundary to 0 for the relations.
  4. Mario Rimann commented on patch set 3 09/06/12, 13:27

    Verified; Looks good to me, but someone else must approve
  5. Steffen Ritter uploaded patch set 3 09/06/12, 13:27

  6. Mr. Jenkins commented on patch set 1 09/06/12, 13:27

  7. Mr. Jenkins commented on patch set 2 09/06/12, 13:27

  8. Mr. Jenkins commented on patch set 3 09/06/12, 13:27

  9. Jigal van Hemert commented on patch set 3 V 0 09/06/12, 13:27

    by team member; Looks good to me, approved
  10. Jigal van Hemert merged patch set 3 09/06/12, 13:27