Review main Merged

14460[BUGFIX] FAL LocalDriverTests throws warnings

Christian Kuhn CR +2 V +2 Normal +171 −53 updated 06/03/13, 20:49

Commit message

finfo() in FAL LocalDriver can not deal with vfs streams and throws
warnings. It is used to fetch the mime type of files.
The patch moves the finfo call to an own method and mocks the methods
in all tests that triggered the warnings.
Additionally, the statReturnsCorrectFileInfo() test is splitted into
four tests and renamed to getLowLevelFileInfoReturnsCorrectFile*. An
additional test is added to test for correct retrieval of mime type
with a prepared dummy file.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3