Review main Merged

14514[BUGFIX] Uncaught Exception when accessing "Filelist" module in Windows

Nicole Hummel CR +2 V +2 Easy +3 −1 updated 06/03/13, 20:49

Commit message

An Exception is thrown when files are found directly in fileadmin folder.
Because of a backslash a false identifier is generated and file cannot be
found anymore.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Wouter Wolters +1
    • Simon Schaufelberger +1
  • Verified V +2
    • Oliver Hader +2
    • Simon Schaufelberger +1

Files 1

Review log 14

  1. Oliver Hader merged patch set 1 09/18/12, 20:07

  2. Mr. Jenkins commented on patch set 1 09/18/12, 20:07

  3. Oliver Hader commented on patch set 3 09/18/12, 20:07

    Looks good to me, approved
  4. Oliver Hader commented on patch set 3 09/18/12, 20:07

    Can you please test again, I don't have a Windows environment running...
  5. Oliver Hader commented on patch set 3 V 0 09/18/12, 20:07

    by team member Thx for testing
  6. Oliver Hader uploaded patch set 3 09/18/12, 20:07

  7. Simon Schaufelberger commented on patch set 2 09/18/12, 20:07

    Verified; Looks good to me, but someone else must approve works very well even though i don't understand why it works in subdirectories
  8. Simon Schaufelberger commented on patch set 3 09/18/12, 20:07

    Verified; Looks good to me, but someone else must approve works very well!
  9. Mr. Jenkins commented on patch set 2 09/18/12, 20:07

  10. Mr. Jenkins commented on patch set 3 09/18/12, 20:07

  11. Wouter Wolters commented on patch set 3 09/18/12, 20:07

    Looks good to me, but someone else must approve
  12. Nicole Hummel uploaded patch set 2 09/18/12, 20:07

  13. Nicole Hummel commented on patch set 2 09/18/12, 20:07

    It works with subdirectories because than dirname returns something like 'folder/'. Without any directory set the return is '\' which is converted to '/\/' and throws the exception.
  14. Nicole Hummel commented on patch set 3 09/18/12, 20:07

    Works for me