Review main Abandoned

14555[FEATURE] Utility Functions to gain information from Class Names

Sebastian Michaelsen CR 0 V 0 Normal +90 −0 updated 06/03/13, 20:49

Commit message

Introduce two Utility functions to the ExtensionManagementUtility
class that
* can truncate a class name by its vendor and package prefix
* can resolve the corresponding extKey for a class name

Review

  • Code review CR 0
  • Verified V 0

Files 2

Review log 16

  1. Sebastian Michaelsen uploaded patch set 2 01/23/13, 11:34

  2. Sebastian Michaelsen uploaded patch set 3 01/23/13, 11:34

  3. Sebastian Michaelsen uploaded patch set 4 01/23/13, 11:34

  4. Sebastian Michaelsen uploaded patch set 5 01/23/13, 11:34

  5. Sebastian Michaelsen uploaded patch set 6 01/23/13, 11:34

  6. Sebastian Michaelsen commented on patch set 7 01/23/13, 11:34

    I would prefer that you didn't submit this I'll check if I can combine my changes with https://review.typo3.org/#/c/17070/ somehow
  7. Sebastian Michaelsen uploaded patch set 7 01/23/13, 11:34

  8. Philipp Gampe commented on patch set 2 01/23/13, 11:34

    I dislike the code duplication. There should be a private method that returns the array with the parts without the vendor/product name and then your two methods should just do their specific code.
  9. Philipp Gampe commented on patch set 2 01/23/13, 11:34

    Looks good to me, but someone else must approve
  10. Philipp Gampe commented on patch set 2 V 0 01/23/13, 11:34

    tested with unit test
  11. Mr. Jenkins commented on patch set 1 01/23/13, 11:34

  12. Mr. Jenkins commented on patch set 2 01/23/13, 11:34

  13. Mr. Jenkins commented on patch set 4 01/23/13, 11:34

  14. Mr. Jenkins commented on patch set 5 01/23/13, 11:34

  15. Mr. Jenkins commented on patch set 7 01/23/13, 11:34

  16. Sebastian Michaelsen commented on patch set 7 01/23/13, 11:34

    Abandoned