14555[FEATURE] Utility Functions to gain information from Class Names
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 2
Review log 16
-
Sebastian Michaelsen uploaded patch set 2 01/23/13, 11:34
-
Sebastian Michaelsen uploaded patch set 3 01/23/13, 11:34
-
Sebastian Michaelsen uploaded patch set 4 01/23/13, 11:34
-
Sebastian Michaelsen uploaded patch set 5 01/23/13, 11:34
-
Sebastian Michaelsen uploaded patch set 6 01/23/13, 11:34
-
Sebastian Michaelsen commented on patch set 7 01/23/13, 11:34
I would prefer that you didn't submit this I'll check if I can combine my changes with https://review.typo3.org/#/c/17070/ somehow -
Sebastian Michaelsen uploaded patch set 7 01/23/13, 11:34
-
Philipp Gampe commented on patch set 2 01/23/13, 11:34
I dislike the code duplication. There should be a private method that returns the array with the parts without the vendor/product name and then your two methods should just do their specific code. -
Philipp Gampe commented on patch set 2 01/23/13, 11:34
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 2 V 0 01/23/13, 11:34
tested with unit test -
Mr. Jenkins commented on patch set 1 01/23/13, 11:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5786/ : SUCCESS -
Mr. Jenkins commented on patch set 2 01/23/13, 11:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5787/ : SUCCESS -
Mr. Jenkins commented on patch set 4 01/23/13, 11:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7027/ : SUCCESS -
Mr. Jenkins commented on patch set 5 01/23/13, 11:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7028/ : SUCCESS -
Mr. Jenkins commented on patch set 7 01/23/13, 11:34
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7030/ : SUCCESS -
Sebastian Michaelsen commented on patch set 7 01/23/13, 11:34
Abandoned