Review main Merged

14567[BUGFIX] Required extensions are not installable

Georg Ringer CR +2 V +2 Easy +11 −1 updated 06/03/13, 20:49

Commit message

Required extensions can't be installed or deinstalled,
therefore the link is not needed. Additionally system
extensions should not be removable.

Review

  • Code review CR +2
    • Susi Moog +2
  • Verified V +2
    • Susi Moog +2

Files 2

Review log 13

  1. Oliver Klee commented on patch set 2 09/22/12, 21:29

    (2 inline comments)

    ToggleExtensionInstallationStateViewHelper.php:51

    We should have a unit test for this case. In addition, these should be ===.

    ToggleExtensionInstallationStateViewHelper.php:54

    There are some trailing tabs here.
  2. Georg Ringer uploaded patch set 2 09/22/12, 21:29

  3. Georg Ringer uploaded patch set 3 09/22/12, 21:29

  4. Mr. Jenkins commented on patch set 1 09/22/12, 21:29

  5. Mr. Jenkins commented on patch set 2 09/22/12, 21:29

  6. Mr. Jenkins commented on patch set 3 09/22/12, 21:29

  7. Susi Moog uploaded patch set 5 09/22/12, 21:29

  8. Susi Moog commented on patch set 5 V 0 09/22/12, 21:29

    by team member; Looks good to me, approved
  9. Mr. Jenkins commented on patch set 4 09/22/12, 21:29

  10. Mr. Jenkins commented on patch set 5 09/22/12, 21:29

  11. Wouter Wolters commented on patch set 4 09/22/12, 21:29

    Looks good to me, but someone else must approve Rmeoved trailing tabs.
  12. Wouter Wolters uploaded patch set 4 09/22/12, 21:29

  13. Steffen Gebert merged patch set 5 09/22/12, 21:29