14567[BUGFIX] Required extensions are not installable
Commit message
Review
-
Code review CR +2
- Susi Moog +2
-
Verified V +2
- Susi Moog +2
Files 2
Review log 13
-
Oliver Klee commented on patch set 2 09/22/12, 21:29
(2 inline comments)ToggleExtensionInstallationStateViewHelper.php:51We should have a unit test for this case. In addition, these should be ===.ToggleExtensionInstallationStateViewHelper.php:54There are some trailing tabs here. -
Georg Ringer uploaded patch set 2 09/22/12, 21:29
-
Georg Ringer uploaded patch set 3 09/22/12, 21:29
-
Mr. Jenkins commented on patch set 1 09/22/12, 21:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5802/ : SUCCESS -
Mr. Jenkins commented on patch set 2 09/22/12, 21:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5803/ : SUCCESS -
Mr. Jenkins commented on patch set 3 09/22/12, 21:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5863/ : SUCCESS -
Susi Moog uploaded patch set 5 09/22/12, 21:29
-
Susi Moog commented on patch set 5 V 0 09/22/12, 21:29
by team member; Looks good to me, approved -
Mr. Jenkins commented on patch set 4 09/22/12, 21:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5870/ : SUCCESS -
Mr. Jenkins commented on patch set 5 09/22/12, 21:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6025/ : SUCCESS -
Wouter Wolters commented on patch set 4 09/22/12, 21:29
Looks good to me, but someone else must approve Rmeoved trailing tabs. -
Wouter Wolters uploaded patch set 4 09/22/12, 21:29
-
Steffen Gebert merged patch set 5 09/22/12, 21:29