Review main Merged

14588[BUGFIX] stdWrap for special.value applied twice

Markus Klein CR +2 V +2 Easy +10 −12 updated 06/27/13, 12:05

Commit message

In HMENU the stdWrap for special.value is applied twice.
This patches removes the superfluous call
in HierarchicalMenuContentObject.php.

Furthermore it also moves the stdWrap for excludeUidList
to AbstractMenuContentObject.php for consistency reasons.

Review

  • Code review CR +2
    • Stefan Neufeind +2
  • Verified V +2
    • Stefan Neufeind +2

Files 2

Review log 14

  1. Markus Klein uploaded patch set 2 05/27/13, 17:19

  2. Markus Klein uploaded patch set 3 05/27/13, 17:19

  3. Philipp Gampe commented on patch set 1 05/27/13, 17:19

    Looks good to me, but someone else must approve
  4. Philipp Gampe commented on patch set 3 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve
  5. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  6. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  7. Mr. Jenkins commented on patch set 3 05/27/13, 17:19

  8. Wouter Wolters commented on patch set 1 05/27/13, 17:19

    Looks good to me, but someone else must approve
  9. Wouter Wolters commented on patch set 3 05/27/13, 17:19

    Looks good to me, but someone else must approve
  10. Markus Klein commented on patch set 3 06/26/13, 21:53

    @Wouter: Yould you mind testing this too and merging it? I can do the backports.
  11. Stefan Neufeind uploaded patch set 4 06/27/13, 12:04

  12. Stefan Neufeind commented on patch set 4 V +2 CR +2 06/27/13, 12:04

    tried out both cases on a local install just rebased patch. Votes from Wouter an Philipp still apply
  13. Stefan Neufeind merged patch set 5 06/27/13, 12:04

  14. Mr. Jenkins commented on patch set 4 06/27/13, 12:05