Review main Abandoned

14668[TASK] Add TCA definition for is_online field in fe_users

Thomas Löffler CR 0 V 0 Easy +17 −2 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 5

  1. Markus Günther commented on patch set 1 02/07/13, 23:22

    In TYPO3 Extbase 6.0 we have dropped the property. See https://review.typo3.org/#/c/16510
  2. Ingo Pfennigstorf commented on patch set 1 02/07/13, 23:22

    (3 inline comments) Maybe there should be a discussion about the field type ...

    tbl_cms.php:302

    I would have done this with type "passthrough" or "none".

    tbl_cms.php:323

    Is it really that important to be shown? Maybe drop this, but there may be other opinions

    locallang_general.xlf:178

    The label "Is online" implies that a simple flag yes/no or checkbox is shown, but not a date/time input field. Maybe we do not need any label at all, depends on the type (see comments in other file).
  3. Mr. Jenkins commented on patch set 1 02/07/13, 23:22

  4. Oliver Salzburg commented on patch set 1 02/07/13, 23:22

    Verified; I would prefer that you didn't submit this I'd prefer it if the required definitions are placed into the TCA and the possible integration into the BE interface should be left for another patch (as already mentioned in previous comments).
  5. Thomas Löffler commented on patch set 1 02/07/13, 23:22

    Abandoned In TYPO3 Extbase 6.0 we have dropped the property. See https://review.typo3.org/#/c/16510