Review main Merged

14854[TASK] Fix CGL violations against SelfMemberReference

Wouter Wolters CR +2 V +2 Easy +4 −1 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2
    • Philipp Gampe +1

Issues 1

Files 2

Review log 16

  1. Georg Ringer commented on patch set 1 09/22/12, 16:00

    Fails
  2. Andy Grunwald commented on patch set 1 09/22/12, 16:00

    Looks good to me, but someone else must approve
  3. Andy Grunwald commented on patch set 1 09/22/12, 16:00

    Fails; I would prefer that you didn't submit this The voilation which was thrown by PHP_CodeSniffer was wrong. This was a bug in PHP_CodeSniffer. The solution is waiting for merge: https://github.com/squizlabs/PHP_CodeSniffer/pull/56 Please have a look at http://forge.typo3.org/issues/41257, too. So this task is on our plan.
  4. Andy Grunwald uploaded patch set 2 09/22/12, 16:00

  5. Philipp Gampe uploaded patch set 4 09/22/12, 16:00

  6. Christian Kuhn commented on patch set 5 V 0 09/22/12, 16:00

    by team member; Looks good to me, approved
  7. Philipp Gampe commented on patch set 5 09/22/12, 16:00

    Verified; Looks good to me, but someone else must approve
  8. Philipp Gampe uploaded patch set 5 09/22/12, 16:00

  9. Andy Grunwald uploaded patch set 3 09/22/12, 16:00

  10. Mr. Jenkins commented on patch set 1 09/22/12, 16:00

  11. Mr. Jenkins commented on patch set 2 09/22/12, 16:00

  12. Mr. Jenkins commented on patch set 3 09/22/12, 16:00

  13. Mr. Jenkins commented on patch set 4 09/22/12, 16:00

  14. Mr. Jenkins commented on patch set 5 09/22/12, 16:00

  15. Wouter Wolters commented on patch set 5 09/22/12, 16:00

    Looks good to me, but someone else must approve Positive vote for the added code by Philip
  16. Christian Kuhn merged patch set 5 09/22/12, 16:00