14854[TASK] Fix CGL violations against SelfMemberReference
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
- Philipp Gampe +1
-
Verified V +2
- Christian Kuhn +2
- Philipp Gampe +1
Issues 1
Files 2
Review log 16
-
Georg Ringer commented on patch set 1 09/22/12, 16:00
Fails -
Andy Grunwald commented on patch set 1 09/22/12, 16:00
Looks good to me, but someone else must approve -
Andy Grunwald commented on patch set 1 09/22/12, 16:00
Fails; I would prefer that you didn't submit this The voilation which was thrown by PHP_CodeSniffer was wrong. This was a bug in PHP_CodeSniffer. The solution is waiting for merge: https://github.com/squizlabs/PHP_CodeSniffer/pull/56 Please have a look at http://forge.typo3.org/issues/41257, too. So this task is on our plan. -
Andy Grunwald uploaded patch set 2 09/22/12, 16:00
-
Philipp Gampe uploaded patch set 4 09/22/12, 16:00
-
Christian Kuhn commented on patch set 5 V 0 09/22/12, 16:00
by team member; Looks good to me, approved -
Philipp Gampe commented on patch set 5 09/22/12, 16:00
Verified; Looks good to me, but someone else must approve -
Philipp Gampe uploaded patch set 5 09/22/12, 16:00
-
Andy Grunwald uploaded patch set 3 09/22/12, 16:00
-
Mr. Jenkins commented on patch set 1 09/22/12, 16:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5911/ : SUCCESS -
Mr. Jenkins commented on patch set 2 09/22/12, 16:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5987/ : SUCCESS -
Mr. Jenkins commented on patch set 3 09/22/12, 16:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5990/ : SUCCESS -
Mr. Jenkins commented on patch set 4 09/22/12, 16:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5992/ : SUCCESS -
Mr. Jenkins commented on patch set 5 09/22/12, 16:00
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5993/ : SUCCESS -
Wouter Wolters commented on patch set 5 09/22/12, 16:00
Looks good to me, but someone else must approve Positive vote for the added code by Philip -
Christian Kuhn merged patch set 5 09/22/12, 16:00