Review main Merged

14864[TASK] Fix CGL violations against DoubleQuoteUsage

Wouter Wolters CR +2 V +2 Easy +13 −7 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 2

Review log 8

  1. Helmut Hummel commented on patch set 1 09/22/12, 14:34

    (1 inline comment)
  2. Georg Ringer commented on patch set 1 09/22/12, 14:34

    Fails

    CategoryCollectionTest.php:273

    \n doesnt work anymore then ...
  3. Mr. Jenkins commented on patch set 1 09/22/12, 14:34

  4. Philipp Gampe commented on patch set 2 09/22/12, 14:34

    Looks good to me, but someone else must approve
  5. Mr. Jenkins commented on patch set 2 09/22/12, 14:34

  6. Wouter Wolters uploaded patch set 2 09/22/12, 14:34

  7. Christian Kuhn commented on patch set 2 V 0 09/22/12, 14:34

    by team member; Looks good to me, approved
  8. Christian Kuhn merged patch set 2 09/22/12, 14:34