Review main Merged

15267[TASK] Make Core\Configuration\ConfigurationManager non static

Helmut Hummel CR +2 V +2 Hard +426 −386 updated 06/03/13, 20:49

Commit message

To have the possibility to remove dependencies from code that
calls the configuration manager, it has to be made non static.

Together with this change, all further configuration file logic
is moved to that class, to not expose internals in other
places. For that some methods needed to be made public, but
have been marked private, thus are not public API.

Further cleanup and simplification, especially not calling
makeInstance several times, will go in a separate change.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 21