Review main Merged

15379[BUGFIX] Support 'input' type in ext_conf_template.txt

Jigal van Hemert CR +2 V +2 Easy +2 −1 updated 06/03/13, 20:49

Commit message

Some older extensions use the type 'input' instead of 'string' in
ext_conf_template.txt . Although it was never documented the TS parser
which was used by the extension manager in previous version did support
this by using the default text field for it.
To improve backwards compatibility the undocumented type is added to the
new EM.

Review

  • Code review CR +2
    • Dmitry Dulepov +2
    • Mattias Nilsson +1
    • Philipp Gampe +1
  • Verified V +2
    • Dmitry Dulepov +2

Files 1

Review log 5

  1. Philipp Gampe commented on patch set 1 10/12/12, 12:32

    Looks good to me, but someone else must approve nobrainer IMHO
  2. Mattias Nilsson commented on patch set 1 10/12/12, 12:32

    Looks good to me, but someone else must approve
  3. Mr. Jenkins commented on patch set 1 10/12/12, 12:32

  4. Dmitry Dulepov commented on patch set 1 V 0 10/12/12, 12:32

    by team member; Looks good to me, approved
  5. Dmitry Dulepov merged patch set 1 10/12/12, 12:32