Review main Merged

15744[BUGFIX] Find abstract functions in compatibility loader

Helmut Hummel CR +2 V +2 Normal +59 −2 updated 06/03/13, 20:49

Commit message

The compatibility class loader rewrites typehints of classes
but fails to find abstract class declarations which end with
an ; and not with a {

Adjust the regular expression to reflect that need.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Wouter Wolters +1
    • Anja Leichsenring +1
  • Verified V +2
    • Helmut Hummel +2
    • Wouter Wolters +1
    • Anja Leichsenring +1

Issues 1

Files 3

Review log 8

  1. Anja Leichsenring commented on patch set 1 10/16/12, 20:44

    (1 inline comment)

    ClassLoaderTest.php:445

    must this test run twice?
  2. Anja Leichsenring uploaded patch set 2 10/16/12, 20:44

  3. Anja Leichsenring commented on patch set 2 10/16/12, 20:44

    Verified; Looks good to me, but someone else must approve
  4. Mr. Jenkins commented on patch set 1 10/16/12, 20:44

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/6320/ : FAILURE
  5. Mr. Jenkins commented on patch set 2 10/16/12, 20:44

  6. Wouter Wolters commented on patch set 2 10/16/12, 20:44

    Verified; Looks good to me, but someone else must approve
  7. Helmut Hummel commented on patch set 2 V 0 10/16/12, 20:44

    by team member; Looks good to me, approved
  8. Helmut Hummel merged patch set 2 10/16/12, 20:44